Fix chart catalog data imports in browser previews - #1240
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change raises builder snapshot limits and adds a total budget. It also maps chart catalog data imports to the local workspace, resolves mapped imports during builds, and rejects imports that escape allowed directories. ChangesBuilder snapshot limits
Catalog workspace imports
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Catalog previews now load local revision-pinned data dependencies and snapshots allow files up to the retained 1 MiB total budget. Current coverage indicates no merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant CatalogLoader as getChartsCatalogExample
participant ModuleResolver as resolveCatalogExampleModule
participant GitSource as Git source
participant Workspace as Example workspace
CatalogLoader->>ModuleResolver: resolve data-prefixed module
ModuleResolver->>ModuleResolver: validate allowed directory
ModuleResolver->>GitSource: fetch resolved data module
GitSource-->>CatalogLoader: return module source
CatalogLoader->>Workspace: add data module and dependencies
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | dd15492 | Commit Preview URL Branch Preview URL |
Sep 09 2026, 04:07 PM |
The shadcn multiple-bar example stays blank on tanstack.com because its revision-pinned esm.sh GitHub data import times out before React mounts. Fetch dataset source and nested dependencies with the existing catalog source closure, then compile local data aliases with the example. Keep the source revision pinned and preserve authored imports.
Allow a single file to use the existing 1 MiB project budget so the largest catalog dataset still saves and shares. The total snapshot limit remains 1 MiB.
Validation:
pnpm test, including TypeScript, lint, and unit tests.readyand renders all 12 bars without console errors.Summary by CodeRabbit
New Features
Bug Fixes