fix(react-start-client): preserve idle hydration deadlines - #8272
fix(react-start-client): preserve idle hydration deadlines#8272LadyBluenotes wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit 81fa70d
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview9 package(s) bumped directly, 16 bumped as dependents. 🟩 Patch bumps
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughIdle hydration now preserves pending work when its timeout remains unchanged. It reschedules when the timeout or strategy changes, cancels work on unmount, and documents and tests these behaviors. ChangesIdle hydration scheduling
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to React idle hydration now retains pending work across rerenders when the timeout is unchanged while preserving rescheduling and cleanup behavior. The covered behavior is ready to merge. Sequence Diagram(s)sequenceDiagram
participant GenericHydrate
participant HydrationStrategy
participant idleSetup
participant BrowserScheduler
GenericHydrate->>HydrationStrategy: Read current strategy and stable key
GenericHydrate->>idleSetup: Invoke _s setup
idleSetup->>BrowserScheduler: Schedule idle hydration
BrowserScheduler-->>GenericHydrate: Run hydration callback
GenericHydrate->>GenericHydrate: Cancel setup on replacement or unmount
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 4 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size BenchmarksThis pull request does not affect bundle size in any measured scenario. |
🎯 Changes
Inline
idle()calls create new strategy objects on each render, which restarted pending hydration. Keep the existing schedule when its timeout is unchanged, while preserving timeout and strategy changes, custom setup overrides, and unmount cleanup.✅ Checklist
🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Documentation