fix(vue-query): widen 'queryOptions' input to match 'useQuery' - #11439
fix(vue-query): widen 'queryOptions' input to match 'useQuery'#11439tinas wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughVue Query now models reactive query options with ChangesVue Query reactivity types
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The Vue Query option types and public exports remain consistent with the intended reactive query-function behavior, with no current merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the motivation, provides a reproduction, and completes the checklist. The Release Impact section is incomplete because neither option is selected, although the changes affect published type exports.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
Options that work inline in
useQuerycould not be extracted intoqueryOptions:Reproduction: https://codesandbox.io/p/devbox/2yzjz5
queryOptionsnow accepts everythinguseQueryaccepts. What it returns is unchanged.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
New Features
skipTokenthrough refs, computed values, and option getters.Documentation