Skip to content

Don't show tags that can cause cyclical dependency. Fixes #1074 - #1258

Open
HEROgold wants to merge 7 commits into
TagStudioDev:mainfrom
HEROgold:main
Open

HEROgold wants to merge 7 commits into
TagStudioDev:mainfrom
HEROgold:main

Conversation

@HEROgold

@HEROgold HEROgold commented Dec 12, 2025

Copy link
Copy Markdown

Summary

Fix for #1074
I've updated the fix made in #1075 to track already visited tags.
I've added helper methods to get tag children/descendants
Creating cyclical parent's is no longer possible, by checking all tag's descendants.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

…v#1074

Use set to avoid duplicate values.
Also include all tag descendants in the exclusion, this avoids showing already parented tags.
Bandaid fix for type error on TagSearchModal: converting to a list

Ideally TagSearchModel can take any Iterable (future fix)
@CyanVoxel CyanVoxel added TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system labels Dec 15, 2025
@TrigamDev TrigamDev added the Type: Fix A fix for a bug, typo, or other issue label Jan 18, 2026
@TrigamDev TrigamDev added the Status: Review Needed A review of this is needed label Mar 1, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review Needed A review of this is needed TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system Type: Fix A fix for a bug, typo, or other issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants