Repository navigation
chore: disable semantic-release success comments #1014 - #1013
Closed
mart-sessman wants to merge 1 commit into
Closed
mart-sessman wants to merge 1 commit into
mart-sessman wants to merge 1 commit into
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The success step looks up every referenced issue via GraphQL, so a reference to #0 fails the release before any condition is evaluated. The comments were never posted anyway: the release job has no issues or pull-requests write permission.
mart-sessman
force-pushed
the
fix/158-release-success-comment
branch
from
October 20, 2026 07:56
7ef0f47 to
950c1bf
Compare
Contributor
Author
|
Closed by a branch rename, replaced by #1015 |
♿ Accessibility — ✅ no blocking violationsNo accessibility violations in the components changed by this PR.
|
| Component | Rules | Stories |
|---|---|---|
| TEDI-Ready/Components/Navigation/Tabs | unknown |
1 |
Stories
- TEDI-Ready/Components/Navigation/Tabs — With Sub Tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1014
Part of TEDI-Design-System/general#158
Sets
"successCommentCondition": falseon@semantic-release/github, so the success step no longer comments on the PRs and issues included in a release.#0(used on dependabot PRs to satisfyreferences-empty) fails the release: the plugin looks up every referenced number via GraphQL, and that lookup throws beforesuccessCommentConditionis evaluated. A condition likeissue.number !== 0cannot prevent it; skipping the step can.issues/pull-requestswrite permission, so every attempt logs "Not allowed to add a comment to the issue/PR".Core already has success comments off.
Cross-repo issue links
The release config moves from
.releaserc.jsontorelease.config.mjs, so it can hold functions. The Angular preset links every#123in a commit subject to this repo's issues, which turnedTEDI-Design-System/general#252into a link to this repo's issue 252. AwriterOpts.finalizeContexthook now pointsowner/repo#123references at the repo they name: