Repository navigation
Pin TA-Lib C only in setup.py - #776
Merged
Merged
Conversation
wheels.yml no longer builds TA-Lib C, so its TALIB_C_VER was read only by tests.yml. Read the version from setup.py instead, so a bump cannot leave the shared-library test on the old release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py's TALIB_C_VERSION is what the wheels and source builds use. wheels.yml's TALIB_C_VER no longer builds anything; only tests.yml read it, to install the system library for the TA_INCLUDE_PATH/TA_LIBRARY_PATH test. This reads the version from setup.py instead and drops the second pin, so bumping TA-Lib C is one edit (plus the README links).