fix(chart): specify custom hosts from values - #311
Merged
Merged
Conversation
…rdcoded subdomains)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Empty frontend hosts can bypass validation, and deployment notes can report an incorrect Keycloak scheme.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the Helm chart to derive ingress and OIDC configuration from configurable frontend and Keycloak hosts.
Changes:
- Replaces custom placeholders with Helm
tplexpressions. - Derives OIDC issuers, TLS hosts, redirects, and deployment notes.
- Updates chart version, lint values, documentation, and changelog.
File summaries
| File | Description |
|---|---|
CHANGELOG.md |
Documents hostname configurability. |
helm-chart/Chart.yaml |
Bumps chart version to 0.4.0. |
helm-chart/templates/NOTES.txt |
Displays configured public hosts. |
helm-chart/templates/_helpers.tpl |
Adds canonical host and issuer helpers. |
helm-chart/templates/backend-configmap.yaml |
Derives backend OIDC configuration. |
helm-chart/templates/frontend-configmap.yaml |
Derives frontend OIDC issuer. |
helm-chart/templates/frontend-ingress.yaml |
Renders templated ingress values. |
helm-chart/values.yaml |
Defines templated hostname defaults. |
tools/helm/lint-values.yaml |
Supplies explicit lint hostnames. |
tools/just/helm.just |
Updates published installation instructions. |
tools/keycloak-handover/README.md |
Documents the required Keycloak hostname. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated Keycloak URL format in NOTES.txt. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sabinem
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We need the ability to specify the keycloak hostname as
hackagon-auth.{baseDomain}but the helpers hard-code someapp/authsubdomains for the frontend and keycloak hosts respectively.As the values expose knobs to set those hostnames, this is highly counter-intuitive.
Summary
The chart no longer hard-codes app. and auth. as the public subdomains. The two values that already looked like hostname work as expected, and are used in templates.
frontend.ingress.hosts, Keycloak's viakeycloak.hostname.hostnameand use them in templates.