Repository navigation
Add short expectation-setter about show if fields - #1146
Merged
Merged
Conversation
Note to users that more fields might appear depending on their answers. This was a direct recommendation from a user in MLH's accessibility testing. Fix #1145
nonprofittechy
approved these changes
Nov 19, 2026
nonprofittechy
left a comment
Member
There was a problem hiding this comment.
Seems fine; willing to trust the experts here. This is a small enough addition (and a complete sentence) that to me I think we can add machine translated version of this phrase to existing translations so we don't break existing interviews translated first pages, but that can be a follow-up PR.
Contributor
Author
|
Thanks for the reminder, I need to get better at remembering translations when doing copyedit updates. I'll can machine translate those bits now in this PR in a separate commit. |
For existing xlsx translations of Spanish, Hatian Creole, and Portuguese (Brazillian),
all from Google Translate. The Creole and Portuguese entries also needed to change
other parts of the screen ("Court Forms Online Project" -> "${ AL_ORGANIZATION_TITLE }" )
to work.
Tested by adding `al_interview_languages` to `al_question_test`. Needed to also update
the `orig_text` in the Portugueses and Creole spreadsheets to be exactly what was in
the question (including a trailing newline).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note to users that more fields might appear depending on their answers. This was a direct recommendation from a user in MLH's accessibility testing.
Stuck with the suggested language, for fear of trying to over explain things.
Fix #1145