Skip to content

Wire the detail drawer, compare sheet, share card, Street View preview and category icon into the map #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
propcgamer20-png wants to merge 2 commits into
base: main
Choose a base branch
from
+2,686 −79
Open

Wire the detail drawer, compare sheet, share card, Street View preview and category icon into the map #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b1d21
Add a required country to every place, a country API filter and a map…
propcgamer20-png Nov 2, 2026
397531b
Wire the detail drawer, compare sheet, share card, Street View previe…
propcgamer20-png Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion data/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ below is also machine-enforced by [`places.schema.json`](places.schema.json), wh
"name": "City Library, Dadar branch",
"type": "library",
"city": "mumbai",
"country": "IN",
"lat": 19.0176,
"lng": 72.8562,
"address": "Gate 2, Gokhale Road, Dadar West",
Expand All @@ -37,7 +38,7 @@ below is also machine-enforced by [`places.schema.json`](places.schema.json), wh
**Fields:**
- `id`: `<city-prefix>-<type>-<number>`. Prefix is a short slug for the city (e.g. `mum`, `thane`, `navi`, `ldn`, `jkt`). Increment from the highest existing number in the file for that prefix.
- `city`: lowercase, underscore-separated slug (e.g. `mumbai`, `navi_mumbai`, `jakarta`). Any city worldwide is welcome, not just Mumbai/Thane/Navi Mumbai. If a city name is already used for a different city, append the state, province, or country (e.g. `london_ontario` or `york_pennsylvania`).
- `country`: optional for now. The place's ISO 3166-1 alpha-2 country code in capitals (e.g. `IN`, `GB`, `KE`), the same codes competitions use. Lowercase or a country name fails `npm run validate`. Existing records are being backfilled, after which it becomes required (#288).
- `country`: required. The place's ISO 3166-1 alpha-2 country code in capitals (e.g. `IN`, `GB`, `KE`), the same codes competitions use. Lowercase or a country name fails `npm run validate`. It powers the map's country filter and the `country` parameter of `/api/places`.
- `type`: must match the filename exactly
- `lat`/`lng`: from Google Maps (right-click pin, "What's here?"). Any real-world coordinate works: `places.schema.json` checks latitude is between -90 and 90 and longitude between -180 and 180.
- `address`: optional, short, human-readable
Expand Down
4 changes: 2 additions & 2 deletions data/places.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "Canonical schema for one entry in data/places/<type>.json. Mirrors the Place type in src/lib/types.ts. See data/CONTRIBUTING.md for the human-readable guide.",
"type": "object",
"additionalProperties": false,
"required": ["id", "name", "type", "city", "lat", "lng", "gmaps_link", "added_by"],
"required": ["id", "name", "type", "city", "country", "lat", "lng", "gmaps_link", "added_by"],
"properties": {
"id": {
"type": "string",
Expand All @@ -30,7 +30,7 @@
"country": {
"type": "string",
"pattern": "^[A-Z]{2}$",
"description": "Optional for now. ISO 3166-1 alpha-2 country code in capitals, e.g. \"IN\", \"GB\". Competitions already use the same codes."
"description": "ISO 3166-1 alpha-2 country code in capitals, e.g. \"IN\", \"GB\". Competitions already use the same codes."
},
"lat": {
"type": "number",
Expand Down
Loading
Loading