Repository navigation
Accept score answers with surrounding whitespace - #97
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (head adf06af):
Notes:
No paths on the do-not-auto-merge list are modified. The PR is considered ready to merge. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createscore answers are now trimmed beforeInteger.parseIntinCreateProjectCommand.getAverageScore, so an answer such as4or4is accepted instead of being rejected withInvalid score. Must be a number between 1 and 5.and re-asking the whole category. This matches how quit tokens already tolerate surrounding whitespace.testScoreAnswerWithSurroundingWhitespaceIsAcceptedwas added toCreateProjectCommandTest. Each padded answer is stubbed to be followed byq, so a regression fails the assertion cleanly instead of re-asking forever (an earlier stub without theqfollow-up made the test executor crash when the fix was reverted).Closes #95
Test plan
./gradlew teston JDK 21: 195 tests executed, 0 failures, 0 errors (counted frombuild/test-results/test/*.xml)git stash: the new test fails withAssertionFailedError; fix restored: it passesSkipped issues
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson