Repository navigation
Document that list accepts --sort none as creation order - #103
Merged
Merged
Conversation
The README said every value outside the supported sort keys is rejected, but `list --sort none` (any capitalization) is accepted and keeps creation order, because `none` is the option's default value. Document it and pin the behaviour with a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (PR #103):
Judgment call noted: README.md:121 — This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invalid sort option...and lists nothing. In factlist --sort none, in any capitalization, is accepted and behaves exactly like omitting--sort(creation order, plainProjects:header), becausenoneis the option's default value (ListProjectsCommand.SORT_NONE, compared withequalsIgnoreCase).--sort none, and a newListProjectsCommandTestcase (shouldKeepCreationOrderWhenNoneIsTypedAsTheSortValue) pins the behaviour using the user-typed spellingNONE, so the doc claim cannot drift silently.noneas accepted was judged consistent with the existing invalid-value message ("or omit --sort to keep creation order"), so it was documented rather than filed as a bug.ProjectRepository,ProjectMarkdownWriterImpl,install.sh,application.yamland both workflows; no other drift was found.Deferred
build.gradle(do-not-auto-merge path) and open design decisions (endpoints, opt-in, port and bind address) that the issue does not yet settle.Test plan
./gradlew teston JDK 21: 202 tests, 0 failures, 0 errors, 0 skipped (counted frombuild/test-results/test/*.xml)No tracking issue — gap found during a documentation sweep.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson