Repository navigation
fix: keep usage reporting off once it is turned off - #101
Merged
Merged
Conversation
Re-vendor trace-client-java 0.8.0 (every opt-out fails closed) and read usage-reporting.enabled through TraceClient.allowsReporting: it used to switch off only for "false", so off, no, 0 or a blank USAGE_REPORTING_ENABLED left reporting on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test Results197 tests ±0 197 ✅ ±0 2s ⏱️ ±0s Results for commit efc6a4d. ± Comparison against base commit 1450c11. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage reporting is now kept off once it has been turned off, following the fail-closed change in the trace client (Stephenson-Software/trace-client-java#51).
TraceClient.javare-vendored at trace-client-java 0.7.0 -> 0.8.0:TRACE_USAGE_REPORTINGset to anything but blank/true/on/yes/1, orDO_NOT_TRACKset to anything but blank/0/false/off/no, turns reporting off.usage-reporting.enabledswitched reporting off only forfalse, sooff,no,0, a typo or a blankUSAGE_REPORTING_ENABLED=left it on. It is now read throughTraceClient.allowsReporting; the defaulttruestill applies when the property is not set at all.Tests
The switch test that pinned
noand0as "on" now checks that they, blank values and typos are off, and that true/on/yes/1 are on../gradlew test: 197 tests, all passing.🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson