Repository navigation
Document that an empty project list wins over an invalid sort value - #100
Merged
Merged
Conversation
list and export report "No projects found" before checking --sort, so an unsupported value goes unreported when nothing is saved. Document that, and that the quit token ignores case and surrounding spaces, and pin the ordering with characterization tests for both commands. Closes #99 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (PR #100):
Judgment notes (non-blocking):
Outcome: no blocking findings. The PR is ready to merge: CI is green, the Phase 7 docs check passed, and no do-not-auto-merge path is touched ( This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listsection now states that the--sortvalue is checked only when projects are saved, so with nonelistprintsNo projects found.whatever--sortwas given. Theexportsection now says the same aboutNo projects found to export.. Both follow fromListProjectsCommand.executeandExportProjectsCommand.executereturning on an empty list beforeProjectSorter.isSupportedSortKeyis called.CreateProjectCommand.readInputtrims and usesequalsIgnoreCase).ListProjectsCommandTest.shouldReportNoProjectsRatherThanAnUnsupportedSortKeyWhenNoneExistandExportProjectsCommandTest.execute_WithNoProjectsAndInvalidSortOption_ShouldReturnNoProjectsMessagepin the empty-list-first ordering. These are characterization tests; production code is unchanged.Closes #99
Test plan
./gradlew teston JDK 21: 197 tests, 0 failures, 0 errors, 0 skipped (counted frombuild/test-results/test/*.xml), including both new testsbuild (21),testandTest Resultsgreen on the PR headDeferred
build.gradle, which is on the do-not-auto-merge list, and the endpoint shapes, opt-in behaviour and bind address have not been decided.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson