Repository navigation
test: pin the greyed journal, the morning radio schedule and a second listen - #57
Merged
Merged
Conversation
… listen The bunkroom's "nothing to write yet" and the radio room's "the schedule goes out on the evening watch" were the only unavailable-option reasons no test asserted, and no test sat in on the schedule twice to hear the repeat line or to see that Dov's game is learned once, on the day it was heard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric:
Repo-specific:
tests/test_scenes.py — the journal test calls Observation: Summary: a test-only PR with green CI; it is ready to merge. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OVERWINTER_*variables,schemas/save.jsonagainstState.toDict, anddocs/STORY.mdagainstfacts.py,people.pyand the scenes were all checked against source. No drift was found, so the cycle fell back to Stage B (unit-test expansion).src/overwinter/sceneswas cross-checked against the tests. Two were asserted nowhere, and they are now pinned intests/test_scenes.py:No tracking issue — gap found during triage. Issue #18 was not picked up: it is still waiting on a story decision among the directions listed in it, which only the author can make.
Test plan
python3 -m pytest— 199 passed (196 before, 3 new)This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson