Skip to content

test: pin the greyed journal, the morning radio schedule and a second listen - #57

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/test-journal-and-schedule-gates
Nov 20, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
feature/test-journal-and-schedule-gates

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

  • A Stage A documentation sweep was run first: README's counts (18 facts, a five-fact trail, three endings, seven places, twenty days, three watches), the food arithmetic (depot = three days at four, seal = two, store empty on the fifteenth night), the calendar days, the OVERWINTER_* variables, schemas/save.json against State.toDict, and docs/STORY.md against facts.py, people.py and the scenes were all checked against source. No drift was found, so the cycle fell back to Stage B (unit-test expansion).
  • Every unavailable-option reason in src/overwinter/scenes was cross-checked against the tests. Two were asserted nowhere, and they are now pinned in tests/test_scenes.py:
    • the bunkroom's "Open your journal" is greyed with "nothing to write yet" until the journal unlock is earned, and is open afterwards;
    • the radio room's "Sit in on the evening schedule" is greyed with "the schedule goes out on the evening watch" outside the evening.
  • A second evening at the schedule is also pinned: the first learns Dov's game and turns the day, the second gives the repeat line ("You do not ask. He does not offer."), learns nothing new and keeps the day the fact was learned.
  • Characterization only: no production code is changed.

No tracking issue — gap found during triage. Issue #18 was not picked up: it is still waiting on a story decision among the directions listed in it, which only the author can make.

Test plan

  • python3 -m pytest — 199 passed (196 before, 3 new)
  • The full-run and ending tests pass unmodified
  • CI green on the PR head

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

… listen

The bunkroom's "nothing to write yet" and the radio room's "the schedule
goes out on the evening watch" were the only unavailable-option reasons no
test asserted, and no test sat in on the schedule twice to hear the repeat
line or to see that Dov's game is learned once, on the day it was heard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric:

  • Scope: PASS — gh pr diff 57 touches only tests/test_scenes.py (two imports, three tests); no production code changed.
  • Tests-new: PASS (not applicable) — no new public method or function is added.
  • Tests-fix: PASS (not applicable) — characterization only; no bug fix to revert.
  • Sibling structure: PASS — the new tests use the file's existing scene() / reasonFor() helpers against FakeGame, and the "the evening was the last watch" assertions mirror test_sitting_up_with_teo_meets_him_and_spends_the_evening.
  • Sibling renames: PASS (not applicable) — nothing renamed.
  • Docs: PASS — no player-visible change, so README, STORY.md, schemas/save.json and version.txt need no edit; the Stage A sweep recorded in the PR body found no drift.
  • Issue resolution: PASS (not applicable) — no Closes #N; the body states no tracking issue exists and why A report to Base after the twelfth day never brings the dark flight, but Dov, the journal and the last page don't know that #18 was skipped.
  • CI: PASS — test (3.8), test (3.12) and docker are green on the PR head.

Repo-specific:

  • Knowledge-gated / Calendar in one place / One RNG / Save format / Flags and endings: PASS (not applicable) — no source change.
  • Solvable: PASS — tests/test_game.py and tests/test_endings.py are unmodified and pass (199 passed locally).
  • Vendored client untouched: PASS — src/overwinter/trace_client.py is not in the diff.

tests/test_scenes.py — the journal test calls progression.catchUp directly because the unlock is otherwise granted by Overwinter.play's loop (progression.getNextUnlock, src/overwinter/game.py:150), which FakeGame does not have; this is deliberate, to keep the test on Bunks.run alone.

Observation: black --check could not be run in this sandbox; CI does not enforce it, and the new lines were written to black's 88-column style by hand.

Summary: a test-only PR with green CI; it is ready to merge.

This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit d4809bc into main Nov 20, 2026
3 checks passed
@dmccoystephenson
dmccoystephenson deleted the feature/test-journal-and-schedule-gates branch November 20, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant