Conversation
Contributor
|
Automated Message: This message has been sent to all open pull requests. Your pull request will be further reviewed once Millennium 3.0.0 is released. We are very busy with Millennium! |
Member
|
Hello, apologies for the incredibly delayed response time! Everything looks good, aside from this. You can use For instance, |
nyakuoff
added a commit
to nyakuoff/protondb-badge
that referenced
this pull request
Sep 21, 2026
The dynamic findClassModule lookup for GameStatWithIcon never engaged because Steam exposes that classname under the property "Playtime", not "GameStatWithIcon" (a label we invented for the KNOWN fallback table). Route the lookup through the real key so it stops silently falling back to the hardcoded April 2026 snapshot value. Per SteamClientHomebrew/PluginDatabase#158 review feedback.
Addresses review feedback on SteamClientHomebrew#158: GameStatWithIcon now resolves via Steam's real "Playtime" module property instead of a name we made up that never matched, so it stops silently falling back to the hardcoded snapshot classname.
Author
|
Hello! Sorry for the delay, i was busy moving. |
Follow-up to the earlier bump: the class-lookup fix now does a real findClassModule search for Steam's "Playtime" property instead of assuming it lived on the already-matched PlayBar module.
Follow-up per SteamClientHomebrew#158 review: classnames are now resolved purely via findClassModule, no April 2026 DOM snapshot fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProtonDB Status shows ProtonDB compatibility ratings directly in Steam’s game details stats row.