Repository navigation
Update Space Engineers VR to 2.0.5 - #383
ColbyJack1134 wants to merge 1 commit into
Conversation
viktor-ferenczi
left a comment
There was a problem hiding this comment.
Review: Space Engineers VR 2.0.5
Scope: hub PR head b67ca5943f136b72ca28ab237dca9644404d5080, manifest Plugins/SpaceEngineersVRPlugin.xml. Version bump 148efd6..dbf1ed0 (v2.0.4 to v2.0.5): 1 commit, 12 files, +144/−277. 11 files (+142/−275) are under SpaceEngineersVR/, the hub build's only source directory. The other one is the Multiplayer assembly's version number.
Summary: No agent-detected blockers. Both low findings from the #376 review are fixed, and the WindowsOpenVR asset is gone, as that review's note suggested. Most of the delta deletes the SmoothFrames CSV recorder. The only new behavior is restoring SmoothFrames interpolation after VR exits.
Manifest and pin
- Hub validator (
python3 test.py Plugins/at the PR head):All files validated. CIxml-checkpassed. - The PR changes
<Commit>and removes theWindowsOpenVRasset.SourceDirectories, the NuGet packages, platforms, runtimes and the other assets are unchanged. dbf1ed0is taggedv2.0.5and is the currentmainHEAD.- No project file, package reference or committed binary changed.
- The repository's own
SpaceEngineersVR.xmlnow matches the hub manifest apart from itsId.
Dropping WindowsOpenVR
OVRSharp 1.2.0 still covers Windows and Proton. Its contentFiles/any/netstandard2.0/openvr_api.dll is 818,904 bytes, SHA-256 c3314d88…c6cee744f, the same file the removed asset pointed to. In a restore for net48, .NET 10 and .NET 10 Linux, project.assets.json marks it copyToOutput: true with output path openvr_api.dll. Pulsar v2.4.3 copies such files into the plugin's Bin folder (NuGetRestore.GetRuntimeFiles, GitHubPlugin L183-L188). Builds no longer download anything from raw.githubusercontent.com on Windows and Proton. On Linux, LinuxOpenVR is still needed and was left alone.
Prior findings
- Fixed: SmoothFrames trace CSVs in the user data root.
SmoothFramesBridge.Record,Save,EndFrame,Eyes,Eye,HoloandRequestare deleted, together with their callers inHeadset,HoloSight,FrameInjections,MotionToolPatchandCockpitRender.TracePose.StereoRenderState.RequestTraceno longer starts a SmoothFrames recording. NoSEVR-smoothframes-*writer is left in the build tree. The single overwrittenSEVR-render-trace.csvstays, as before. - Fixed: interpolation stays off after VR exits.
Failnow remembers that it turnedSmoothFrames.Plugin.InterpolationEnabledoff, and only does so if it was on.RestoreInterpolationsets the field back from SmoothFrames' savedPlugin.Config.InterpolationEnabled, so a Ctrl+F11 toggle made while the bridge was failed wins. Both members exist at the SmoothFrames hub pin34fbd41(Plugin.csL23-L25,PluginConfig.csL26). The restore runs from VR cleanup when VR is fully gone (Main.UpdateL238) and fromStop/Dispose. During the VR menu fallback it waits, andAllowSmoothingnow keys onVrPresentinstead ofVrActive, so the guard keeps blocking SmoothFrames'RunFramethere too. The newInterpolationRestoretest inDiagnostics/covers enabled and disabled starting states, a dispose versus a desktop fallback, and a setting changed during the failure. That file is under#if SEVR_DIAGNOSTICSand not in the hub build.
Security
The added lines contain no file, process, network, environment, assembly loading or native interop calls. The bridge's only file write (Save, via Task.Run) is deleted, along with its System.IO and VRage.FileSystem imports. The new reflection reads the fixed Config and InterpolationEnabled members of the SmoothFrames type the bridge already patched. The bridge no longer patches CameraCapture.PublishPendingSnap.
From-source build
I built SpaceEngineersVR/**/*.cs with C# 14 in Release against the installed game Bin64, Harmony 2.4.2, Mono.Cecil 0.11.6 and the two hub packages. I used the same MSBuild harness as for #376, not the repository's project file:
| Symbols | Errors | Compiler warnings |
|---|---|---|
net48, TRACE;NETFRAMEWORK;PULSAR |
0 | 0 |
.NET 10, TRACE;NETCOREAPP;PULSAR |
0 | SYSLIB0050 |
.NET 10, TRACE;NETCOREAPP;LINUX;PULSAR |
0 | SYSLIB0050, CS0649 (same as 2.0.4) |
I didn't run it in a game. Testing it needs a SteamVR headset.
This is a small follow-up release to address the feedback in PluginHub PR #376. It updates the Space Engineers VR pin from v2.0.4 (
148efd6) to v2.0.5 (dbf1ed0).openvr_api.dll. OVRSharp 1.2.0 supplies the same DLL. Windows Pulsar installs with fresh and existing NuGet caches produced the expected SHA-256. The earlier missing DLL was traced to an incomplete test cache.