Skip to content

Update Space Engineers VR to 2.0.5 - #383

Open
ColbyJack1134 wants to merge 1 commit into
StarCpt:mainfrom
ColbyJack1134:update-space-engineers-vr-2.0.5
Open

ColbyJack1134 wants to merge 1 commit into
StarCpt:mainfrom
ColbyJack1134:update-space-engineers-vr-2.0.5

Conversation

@ColbyJack1134

Copy link
Copy Markdown
Contributor

This is a small follow-up release to address the feedback in PluginHub PR #376. It updates the Space Engineers VR pin from v2.0.4 (148efd6) to v2.0.5 (dbf1ed0).

  • Removes the per-session SmoothFrames CSV recorder. The stereo render trace remains available.
  • Restores the player’s latest SmoothFrames interpolation preference when VR exits after a compatibility failure.
  • Removes the separate Windows and Proton download of openvr_api.dll. OVRSharp 1.2.0 supplies the same DLL. Windows Pulsar installs with fresh and existing NuGet caches produced the expected SHA-256. The earlier missing DLL was traced to an incomplete test cache.

@viktor-ferenczi viktor-ferenczi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Space Engineers VR 2.0.5

Scope: hub PR head b67ca5943f136b72ca28ab237dca9644404d5080, manifest Plugins/SpaceEngineersVRPlugin.xml. Version bump 148efd6..dbf1ed0 (v2.0.4 to v2.0.5): 1 commit, 12 files, +144/−277. 11 files (+142/−275) are under SpaceEngineersVR/, the hub build's only source directory. The other one is the Multiplayer assembly's version number.

Summary: No agent-detected blockers. Both low findings from the #376 review are fixed, and the WindowsOpenVR asset is gone, as that review's note suggested. Most of the delta deletes the SmoothFrames CSV recorder. The only new behavior is restoring SmoothFrames interpolation after VR exits.

Manifest and pin

  • Hub validator (python3 test.py Plugins/ at the PR head): All files validated. CI xml-check passed.
  • The PR changes <Commit> and removes the WindowsOpenVR asset. SourceDirectories, the NuGet packages, platforms, runtimes and the other assets are unchanged.
  • dbf1ed0 is tagged v2.0.5 and is the current main HEAD.
  • No project file, package reference or committed binary changed.
  • The repository's own SpaceEngineersVR.xml now matches the hub manifest apart from its Id.

Dropping WindowsOpenVR

OVRSharp 1.2.0 still covers Windows and Proton. Its contentFiles/any/netstandard2.0/openvr_api.dll is 818,904 bytes, SHA-256 c3314d88…c6cee744f, the same file the removed asset pointed to. In a restore for net48, .NET 10 and .NET 10 Linux, project.assets.json marks it copyToOutput: true with output path openvr_api.dll. Pulsar v2.4.3 copies such files into the plugin's Bin folder (NuGetRestore.GetRuntimeFiles, GitHubPlugin L183-L188). Builds no longer download anything from raw.githubusercontent.com on Windows and Proton. On Linux, LinuxOpenVR is still needed and was left alone.

Prior findings

  • Fixed: SmoothFrames trace CSVs in the user data root. SmoothFramesBridge.Record, Save, EndFrame, Eyes, Eye, Holo and Request are deleted, together with their callers in Headset, HoloSight, FrameInjections, MotionToolPatch and CockpitRender.TracePose. StereoRenderState.RequestTrace no longer starts a SmoothFrames recording. No SEVR-smoothframes-* writer is left in the build tree. The single overwritten SEVR-render-trace.csv stays, as before.
  • Fixed: interpolation stays off after VR exits. Fail now remembers that it turned SmoothFrames.Plugin.InterpolationEnabled off, and only does so if it was on. RestoreInterpolation sets the field back from SmoothFrames' saved Plugin.Config.InterpolationEnabled, so a Ctrl+F11 toggle made while the bridge was failed wins. Both members exist at the SmoothFrames hub pin 34fbd41 (Plugin.cs L23-L25, PluginConfig.cs L26). The restore runs from VR cleanup when VR is fully gone (Main.Update L238) and from Stop/Dispose. During the VR menu fallback it waits, and AllowSmoothing now keys on VrPresent instead of VrActive, so the guard keeps blocking SmoothFrames' RunFrame there too. The new InterpolationRestore test in Diagnostics/ covers enabled and disabled starting states, a dispose versus a desktop fallback, and a setting changed during the failure. That file is under #if SEVR_DIAGNOSTICS and not in the hub build.

Security

The added lines contain no file, process, network, environment, assembly loading or native interop calls. The bridge's only file write (Save, via Task.Run) is deleted, along with its System.IO and VRage.FileSystem imports. The new reflection reads the fixed Config and InterpolationEnabled members of the SmoothFrames type the bridge already patched. The bridge no longer patches CameraCapture.PublishPendingSnap.

From-source build

I built SpaceEngineersVR/**/*.cs with C# 14 in Release against the installed game Bin64, Harmony 2.4.2, Mono.Cecil 0.11.6 and the two hub packages. I used the same MSBuild harness as for #376, not the repository's project file:

Symbols Errors Compiler warnings
net48, TRACE;NETFRAMEWORK;PULSAR 0 0
.NET 10, TRACE;NETCOREAPP;PULSAR 0 SYSLIB0050
.NET 10, TRACE;NETCOREAPP;LINUX;PULSAR 0 SYSLIB0050, CS0649 (same as 2.0.4)

I didn't run it in a game. Testing it needs a SteamVR headset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants