Repository navigation
Update Korean Localization Plugin to 1.1.0 - #378
Merged
viktor-ferenczi merged 2 commits intoNov 18, 2026
Merged
viktor-ferenczi merged 2 commits into
viktor-ferenczi merged 2 commits into
Conversation
viktor-ferenczi
left a comment
Collaborator
There was a problem hiding this comment.
Version bump review at hub head f4d5c0a: Arstraea/Korean-Localization-Plugin 0c1a684..2d5b5a6 (the direct git diff of the old and new pins, 12 files, +572/−14).
No agent-detected blockers.
Manifest and pin
- The hub diff changes only
<Commit>. Id, RepoId,Source/,CLR/Windowsand the hidden pack dependency 1843839106 are unchanged.test.py Pluginsat the PR head: "All files validated". 2d5b5a6ismainHEAD, so there's no drift. The range has three commits (4ef73b6,6915202,2d5b5a6). Thev1.0.0andv1.0.1tags exist, but there's nov1.1.0tag. That's fine, since the hub pins the commit.- No package, NuGet, binary, native, submodule or symlink changes. The only new project reference is
SpaceEngineers.ObjectBuildersfrom the game'sBin64, whichMyObjectBuilder_Datapadneeds. Pulsar references the game assemblies anyway.
Security
- New code:
DatapadProtection.cs,DatapadTranslationState.csandEconomyDatapadCatalog.cs. The rest is version strings, news text, docs and a newLICENSE. - No networking, process execution or dynamic code.
Assembly.Load("Sandbox.Game")and the reflection inInstall(L43-L68) only look up fixed game types and fields. - The only new file access is a read of the pack's
Data/Localization/MyTexts.resx(TranslationInstaller.csL122-L125). It goes through the existingFilePaths.Read/RejectLinkschecks, usesXmlReaderwithDtdProcessing.Prohibitand no resolver (L30-L42), and keeps only the 18*_EconomyStation1..9entries. The regexes built from them are escaped and have a 50 ms timeout. Nothing is written.
Game hooks and authority
Checked against the decompiled MyGuiDatapadEditScreen and MyGuiScreenMessageBox of SE 1.211.017:
- Every field the patches inject or read exists (
m_datapad,m_textboxName,m_textbox,m_characterCountLabel,m_okButton,m_createGpsCoord,m_yesButton,m_noButton,m_messageBoxText). OkButtonClickedhas exactly oneMyGuiControlTextbox::get_Textcall and oneObject::ToStringcall, which matches what the transpiler checks (L215-L221). It only passes those two values throughSaveTitle/SaveBodyright before the stockModifyDatapadevent. If the IL changes, it throws, andPatchTransactionrolls back both patches, so the editor falls back to stock behavior.- An unedited datapad closes without sending anything. Without the plugin, OK would overwrite stored
{LOC:…}keys with the reader's language. When only one field of a keyed pad is edited, the other field sends its original keys (DatapadTranslationState.csL58-L59). - The values sent are plain title and body strings, the same ones a vanilla player could type, and they go through the stock event. Server authority is unchanged.
- No other PluginHub or MagnetarHub plugin in the local source index patches
MyGuiDatapadEditScreen.
From-source build
All Source/**/*.cs files compiled with Roslyn csc directly (SDK 10.0.400, net48 reference assemblies, x64), against SE 1.211.017 Bin64 and Pulsar's Legacy 0Harmony/Mono.Cecil. Both -langversion:7.3 (the csproj's setting) and latest give 0 errors and 0 warnings for 2d5b5a6. Not load-tested: the plugin is Windows/CLR only.
Non-blocking note
- Note for hub maintainers: this bump adds a custom source-available
LICENSE. It explicitly allows inspection, Pulsar compilation and caching, personal use, and reviewer testing. Modification and redistribution need Arstraea's written permission. The hub only builds the pinned source, so the hub workflow doesn't conflict with it. It does mean nobody else may publish a fixed fork if the plugin breaks while the author is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Korean Localization Plugin to 1.1.0 (assembly version 1.1.0.0).
Public source: 2d5b5a6.
Changes
The Windows/CLR restriction, plugin GUID, resource-pack dependency, external cache layout, and read-only handling of the game installation are unchanged. No new dependencies or server-side changes are required. The pack's existing English datapad templates supply the matching data; the plugin does not retain or copy a full English localization dictionary.
Validation
This PR updates the existing plugin's pinned public source commit only; the hidden resource-pack descriptor remains unchanged.