Skip to content

Update Korean Localization Plugin to 1.1.0 - #378

Merged
viktor-ferenczi merged 2 commits into
StarCpt:mainfrom
Arstraea:codex/update-korean-localization-plugin-1.1.0
Nov 18, 2026
Merged

viktor-ferenczi merged 2 commits into
StarCpt:mainfrom
Arstraea:codex/update-korean-localization-plugin-1.1.0

Conversation

@Arstraea

@Arstraea Arstraea commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Updates Korean Localization Plugin to 1.1.0 (assembly version 1.1.0.0).

Public source: 2d5b5a6.

Changes

  • Datapads containing localization keys now close without a save request when confirmed without edits. Saving edits requires confirmation, and unchanged title/body fields retain their original keys.
  • Nine recognized English economy-station GPS datapad templates can be displayed in Korean. Generated station names and GPS values are preserved. Confirming without edits does not save; editing either field saves the displayed title and body together through the stock save path. These plain-text items do not receive the localization-key warning. Unrecognized text is left unchanged.
  • The existing introductory release notes are retained, with one additional datapad feature entry and the new release version.
  • English reviewer comments for the datapad UI messages now match the current Korean wording. This source refresh changes comments only; runtime behavior and Korean text are unchanged.

The Windows/CLR restriction, plugin GUID, resource-pack dependency, external cache layout, and read-only handling of the game installation are unchanged. No new dependencies or server-side changes are required. The pack's existing English datapad templates supply the matching data; the plugin does not retain or copy a full English localization dictionary.

Validation

  • Compiled with the installed Pulsar 2.4.3 Legacy / CLR compiler against Space Engineers 1.211.017 (Warfare 3). The embedded news and source XML were checked for consistency.
  • PluginHub's descriptor validator passed locally.
  • Isolated checks exercised actual input hooks, native text/font consumers, datapad editor/save hooks, and the stock confirmation dialog. GPU submission and network requests were intercepted.
  • In-game checks confirmed the datapad notice and confirmation layout, and Korean title/body display and edited-body saving on a foreign dedicated server. The final title/body joint-save adjustment is covered by isolated checks; a complete multiplayer retest of this exact revision has not been performed.

This PR updates the existing plugin's pinned public source commit only; the hidden resource-pack descriptor remains unchanged.

@viktor-ferenczi viktor-ferenczi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump review at hub head f4d5c0a: Arstraea/Korean-Localization-Plugin 0c1a684..2d5b5a6 (the direct git diff of the old and new pins, 12 files, +572/−14).

No agent-detected blockers.

Manifest and pin

  • The hub diff changes only <Commit>. Id, RepoId, Source/, CLR/Windows and the hidden pack dependency 1843839106 are unchanged. test.py Plugins at the PR head: "All files validated".
  • 2d5b5a6 is main HEAD, so there's no drift. The range has three commits (4ef73b6, 6915202, 2d5b5a6). The v1.0.0 and v1.0.1 tags exist, but there's no v1.1.0 tag. That's fine, since the hub pins the commit.
  • No package, NuGet, binary, native, submodule or symlink changes. The only new project reference is SpaceEngineers.ObjectBuilders from the game's Bin64, which MyObjectBuilder_Datapad needs. Pulsar references the game assemblies anyway.

Security

  • New code: DatapadProtection.cs, DatapadTranslationState.cs and EconomyDatapadCatalog.cs. The rest is version strings, news text, docs and a new LICENSE.
  • No networking, process execution or dynamic code. Assembly.Load("Sandbox.Game") and the reflection in Install (L43-L68) only look up fixed game types and fields.
  • The only new file access is a read of the pack's Data/Localization/MyTexts.resx (TranslationInstaller.cs L122-L125). It goes through the existing FilePaths.Read/RejectLinks checks, uses XmlReader with DtdProcessing.Prohibit and no resolver (L30-L42), and keeps only the 18 *_EconomyStation1..9 entries. The regexes built from them are escaped and have a 50 ms timeout. Nothing is written.

Game hooks and authority

Checked against the decompiled MyGuiDatapadEditScreen and MyGuiScreenMessageBox of SE 1.211.017:

  • Every field the patches inject or read exists (m_datapad, m_textboxName, m_textbox, m_characterCountLabel, m_okButton, m_createGpsCoord, m_yesButton, m_noButton, m_messageBoxText).
  • OkButtonClicked has exactly one MyGuiControlTextbox::get_Text call and one Object::ToString call, which matches what the transpiler checks (L215-L221). It only passes those two values through SaveTitle/SaveBody right before the stock ModifyDatapad event. If the IL changes, it throws, and PatchTransaction rolls back both patches, so the editor falls back to stock behavior.
  • An unedited datapad closes without sending anything. Without the plugin, OK would overwrite stored {LOC:…} keys with the reader's language. When only one field of a keyed pad is edited, the other field sends its original keys (DatapadTranslationState.cs L58-L59).
  • The values sent are plain title and body strings, the same ones a vanilla player could type, and they go through the stock event. Server authority is unchanged.
  • No other PluginHub or MagnetarHub plugin in the local source index patches MyGuiDatapadEditScreen.

From-source build

All Source/**/*.cs files compiled with Roslyn csc directly (SDK 10.0.400, net48 reference assemblies, x64), against SE 1.211.017 Bin64 and Pulsar's Legacy 0Harmony/Mono.Cecil. Both -langversion:7.3 (the csproj's setting) and latest give 0 errors and 0 warnings for 2d5b5a6. Not load-tested: the plugin is Windows/CLR only.

Non-blocking note

  • Note for hub maintainers: this bump adds a custom source-available LICENSE. It explicitly allows inspection, Pulsar compilation and caching, personal use, and reviewer testing. Modification and redistribution need Arstraea's written permission. The hub only builds the pinned source, so the hub workflow doesn't conflict with it. It does mean nobody else may publish a fixed fork if the plugin breaks while the author is unavailable.

@viktor-ferenczi
viktor-ferenczi merged commit d806218 into StarCpt:main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants