Repository navigation
Update Marigold to 0.17.16 for Pulsar Legacy and Interim - #362
Conversation
|
Passed local agent review. Ready for official review. |
viktor-ferenczi
left a comment
There was a problem hiding this comment.
Review: Marigold 0.17.15 → 0.17.16 (version bump, adds Interim)
Scope: hub PR head 2534ea0ce57a49f267c4cf33daab294e223a4306, manifest Plugins/Marigold.xml, source range Taeleus/Marigold 5652cd9..b813fcc (8 commits, including the merge of Taeleus/Marigold#3). I read the whole direct diff: 40 files, +739/−1,044. Of that, src/Marigold.Plugin is 11 files (+452/−85), tests/ is one file (+10), and the rest is docs, .gitignore and prepare-release.ps1.
Summary: No security findings. The code changes gate station mode on ownership and let the GPU renderer keep its shaders between ships. Nothing new reaches the network, processes, files or dynamic code. One Medium finding: adding CoreCLR with no <Platforms> also offers Marigold to Pulsar Interim on native Linux, where Textured Ship can't find the vanilla models and always falls back to wireframe. Interim on Windows isn't affected.
Manifest
- Changed:
<Commit>,<Description>, and<Runtimes>fromCLRtoCLR;CoreCLR.Id,RepoId,SourceDirectories(src/Marigold.Plugin) and the absence ofNuGetReferencesare unchanged. - There is no
<Platforms>, so Pulsar013a108(Tools.IsSupportedEnvironment) offers the entry everywhere: Legacy on Windows and Proton, Interim on Windows and Linux. python3 test.py Plugins/at the PR head:All files validated. The repository's ownMarigold.xmlmatches the hub entry apart fromRepoId/Commit.
Repository and pin provenance
b813fccis the currentmasterHEAD (comparereportsidentical). It is 8 commits ahead of the old pin and 0 behind. Still public and MIT, still no tags.- No binaries, native files, submodules, symlinks or package files were added.
Marigold.Plugin.csprojonly bumps<Version>, and its references are unchanged: game and SharpDX DLLs from$(Bin64), plusLib.Harmony2.4.2, which Pulsar supplies as0Harmony. prepare-release.ps1only writesCLR;CoreCLRinto the release manifest.
Security
- Station mode:
HasStationAccesscounts ownership-capable fat blocks and admits a grid only when the local player owns a strict majority of them, or faction members share a strict majority with the faction. It reads replicated client state and only feeds the HUD. 0.17.15 showed every connector-linked grid, so this narrows what the plugin shows. It never writes to the server. - Events: grid, connector and faction handlers are removed in
StationGridAccess.DisposeandClearStationAccess. Handlers that can fire off the game thread only setInterlockedflags (MarkStationGraphChanged). An access scan walks the fat blocks of the station and at most 8 docked grids, once per 60 HUD updates and not while the HUD is hidden. - GPU renderer:
ClearScenekeeps compiled shaders and states for the next ship, and any exception still releases the whole pipeline (GpuShipRenderer.cs#L147-L156). There are no new reflection targets or Harmony patches. - Not present in the diff: network access, process launch, file I/O, assembly loading, P/Invoke, encoded payloads, self-update.
From-source build
I compiled all 68 .cs files in src/Marigold.Plugin for net10.0 with the settings of Pulsar 013a108's RoslynCompiler: C# 14, unsafe allowed, no LOCAL_BUILD, no generated assembly info. I built it twice, with NETCOREAPP;PULSAR (Interim on Windows) and with NETCOREAPP;LINUX;PULSAR (Interim on Linux), each in Release and Debug. References were the SpaceEngineers*/VRage*/Sandbox*/ProtoBuf* DLLs (without VRage.Native.dll) and the SharpDX DLLs from SE 1.211.017 Bin64, Pulsar Interim's 0Harmony 2.4.2 and the .NET 10 reference pack. All four builds: 0 errors, 0 warnings. This was a scratch project built with the .NET 10.0.400 SDK, not Pulsar's compiler process, and I didn't load the plugin in game.
Findings
Medium: Textured Ship doesn't work on Pulsar Interim on Linux
The mesh capture opens model files with plain System.IO, using the path the game stores in MyModel.AssetName (TexturedShipMesh.cs#L157, #L1176). For base-game blocks that is the raw SBC value, such as Models\Cubes\Large\Structural_3_frame.mwm. In SE 1.211.017, MyDefinitionManager.InitDefinition runs UpdateModableContent only for mod contexts, and the MyModel(string, bool) constructor stores the name unchanged. On Linux \ is not a separator, so Path.Combine(contentRoot, asset) names a file that doesn't exist and IsSafeAsset rejects it. LinuxCompat normalizes these paths only inside the game's own code: in the model importer and in ProcessContentFilePath for mod definitions. A plugin's own file access gets neither. Texture paths read from MWM materials (#L1163) have the same problem. Paths with the right separators can still fail where the SBC casing differs from the files on disk, because Linux file systems are case-sensitive.
As a result, LoadTemplate fails for every vanilla model (#L1038), the build throws "No readable ship meshes were available." (#L752), and the HUD falls back to wireframe with "Textured ship unavailable", trying again every 10 s (TexturedShipPreview.cs#L104). Nothing crashes, but on Linux Interim players can't use Textured Ship, which the listing advertises and which is the GPU default. I traced this through the code and did not run it on Linux. The Interim checks in the PR and in Taeleus/Marigold#3 were done on Windows only.
Fix, either:
- add
<Platforms>Windows;Proton</Platforms>until Marigold has been tested on Linux Interim. Legacy under Proton and Interim on Windows keep working; or - resolve assets the way the game does on both systems: turn
\intoPath.DirectorySeparatorCharbefore combining, and look the files up case-insensitively (LinuxCompat makesMyFileSystem.FileExistsandMyFileSystem.OpenReaddo both). Then run the CPU and GPU Textured Ship checks on Linux Interim.
|
Thanks for catching the native Linux issue. I’ve updated the manifest to use The PR now pins |
viktor-ferenczi
left a comment
There was a problem hiding this comment.
Re-review: Marigold 0.17.15 → 0.17.16 (version bump, adds Interim)
Scope: hub PR head 6c195d8a1e81b3680eefbd58389739c3c576b2c7, manifest Plugins/Marigold.xml, source range Taeleus/Marigold 5652cd9..2791f99 (9 commits, 40 files, +742/−1,044). The previous review covered hub head 2534ea0 with source pin b813fcc. Since then the hub PR has one commit (6c195d8), and the source has one commit, 2791f99, on top of b813fcc.
Summary: The Medium finding is fixed. No new findings.
Reply to @Taeleus
Thanks, Windows;Proton was the right call. Pulsar v2.4.3 (013a108) reports Linux as the platform for native Linux Interim (Tools.Platform) and checks runtime and platform separately (IsSupportedEnvironment), so the entry is now offered to Legacy and Interim on Windows and under Proton, and not to native Linux. Under Proton the plugin runs as a Windows process, where \ is a separator and Wine looks up file names case-insensitively, so the path problem in Textured Ship doesn't apply there. The ROADMAP item for native Linux Interim describes the fix that's needed.
Prior findings
| Finding | Status |
|---|---|
| Medium: Textured Ship doesn't work on Pulsar Interim on Linux | Fixed. The hub manifest adds <Platforms>Windows;Proton</Platforms> and keeps <Runtimes>CLR;CoreCLR</Runtimes>. |
Manifest
- Changed since the last review:
<Commit>fromb813fcc…to2791f992ebd30d92f329cf8d988422f55f696c1d, and the new<Platforms>Windows;Proton</Platforms>.Id,RepoId,Description,Runtimes,SourceDirectoriesand the absence ofNuGetReferencesare unchanged. Other hub entries already use the sameWindows;Protonvalue, such asSMAA.xmlandScreenSpaceGI.xml. python3 test.py Plugins/at6c195d8:All files validated.- The repository's
Marigold.xmlat2791f99now has the samePlatformsandRuntimes.prepare-release.ps1starts from that file and overwrites onlyRepoId,CommitandRuntimes, so a generated hub manifest keeps the platform filter.
Repository and pin provenance
2791f99is the currentmasterHEAD (comparereportsidentical). The repository is still public and MIT.b813fcc..2791f99changes 6 files (+9/−6):Marigold.xml(thePlatformsline) and wording inCHANGELOG.md,ROADMAP.md,docs/API-EVIDENCE.md,docs/PLUGINHUB-PLAN.mdanddocs/RELEASE.md.git diff b813fcc 2791f99 -- src tests prepare-release.ps1is empty, so the compiled source (src/Marigold.Plugin, 11 files changed +452/−85 over the full range) is byte-identical to what the previous review covered.
Security and from-source build
The compiled source didn't change, so the security review and the four net10.0 builds in the previous review (0 errors, 0 warnings) still apply to this pin. No binaries, native files, submodules or package references were added in the new commit.
Updates Marigold from 0.17.15 to 0.17.16. The PluginHub entry now targets Pulsar Legacy (
CLR) and Interim (CoreCLR) on Windows and Proton and pinsTaeleus/Marigoldat2791f992ebd30d92f329cf8d988422f55f696c1d.The platform filter keeps Proton setups eligible, including Bazzite through Proton. Native Linux Interim is deferred until Textured Ship can resolve model and texture paths on Linux and both renderers are tested there.
Changes
/mg captureor Baselines > Capture this ship in/mg ui.Validation
Changelog · Source changes since 0.17.15 · Interim contribution