docs: publish security review and remediation for contract sandbox escape - #154
Merged
Merged
Conversation
…cape Finding 1 (sandbox escape via str.format() attribute traversal, Critical) is fully remediated by commit 3ca9596 / PR #152, now merged into main. Moving the review and its remediation report out of the private, gitignored unremediated-security-reviews/ folder into the public, tracked security-reviews/ folder per the security-remediation workflow.
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str.format()attribute-chain traversal bypassing the AST dunder blocklist inminichain/contract.py).3ca9596(merged via fix: close contract sandbox escape via str.format() attribute traversal #152) implements the review's recommendation.unremediated-security-reviews/folder into the public, trackedsecurity-reviews/folder, per thesecurity-remediationskill workflow added in chore: add security-review and security-remediation skills #153.Test plan
unremediated-security-reviews/no longer contains either file after the move.