Repository navigation
Renormalize gradlew.bat line endings - #87
Merged
Merged
Conversation
`.gitattributes` marks `*.bat` as `text eol=crlf`, which requires the blob to be stored LF-normalized and converted to CRLF on checkout. The committed blob was stored with CRLF instead, so Git reported the file as modified on every fresh clone or submodule checkout, for everyone, with no actual edits. `git add --renormalize` rewrites only the stored line endings; checkouts still materialize CRLF per the attribute, and the script's content is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
armiol
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitattributesmarks*.batastext eol=crlf, which requires the blob to bestored LF-normalized and converted to CRLF on checkout. The committed blob was
stored with CRLF instead, so Git reports
gradlew.batas modified on every freshclone or submodule checkout — for everyone, with no actual edits. The phantom
modification also blocks branch switching over the file.
git add --renormalize gradlew.batrewrites only the stored line endings. Checkoutsstill materialize CRLF per the attribute, and the script's content is unchanged.
Verification
origin/masterblob (git show origin/master:gradlew.bat | cmp - gradlew.bat)while
git statusstill reports it modified — proving the marker is a storageartifact, not an edit.
git statusis clean and the working file still has CRLFterminators (
file gradlew.batsays "DOS batch file text, ... CRLF").🤖 Generated with Claude Code