[alexander-yevsyukov]

What

Project.configureTaskDependencies() now orders the KSP tasks after the Protobuf code generation:

• kspKotlin → generateProto
• kspTestKotlin → generateTestProto
• kspTestFixturesKotlin → generateTestFixturesProto

The edges use the function's local String.dependOn(taskName) helper, so they are lazy and do nothing in a module that lacks either task. They sit next to the existing compileKotlin → generateProto wiring.

The test-fixtures edge has no current failure behind it. The only consumer modules with test-fixture protos and KSP use the Spine Compiler, which already orders KSP. It is included because configureTaskDependencies() already wires kspTestFixturesKotlin, and the cause is the same for every source set.

Why

KSP reads the sources that the Protobuf tasks generate. In a module that applies both protobuf and KSP, nothing ordered KSP after generateProto, so Gradle failed the build on an implicit dependency. This came up in the scoped refresh wave closed by #836: base-libraries had to add the wiring by hand in base/build.gradle.kts (SpineEventEngine/base-libraries#969).

In modules that use the Spine Compiler, the new edge changes nothing. The Compiler plugin already makes kspX depend on its launch task, and that task depends on generateXProto. Nothing makes generateProto depend on KSP or on the Compiler, so the new edge cannot create a cycle.

Consumer follow-up

After their next ./config/pull:

• base-libraries can drop its local copy (the mapOf("kspKotlin" to "generateProto", …) block in base/build.gradle.kts).
• validation has no copy of this wiring to drop. Its two local blocks wire KSP against launchSpineCompiler, not generateProto:
  • context/build.gradle.kts (kspKotlin → launchSpineCompiler) is already redundant, because the Spine Compiler plugin adds that edge itself.
  • tests/validator/build.gradle.kts adds the opposite edge (launchSpineCompiler → kspKotlin), because the Compiler consumes KSP output there. This change does not affect it.

Tests

BuildExtensionsSpec gets a new group with three ProjectBuilder tests:

• all three edges are added;
• KSP tasks registered after evaluation still get the edges;
• nothing is added when the project has no Protobuf tasks.

Against master's BuildExtensions.kt, the first two fail.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-05T20:08:29.644826Z	34a9ad0	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[Copilot]

🟢 Approved

The shared KSP-to-Protobuf task dependency change has no active review issues blocking approval.

No open issues 🎉

What changed in this PR

Ensures KSP runs after Protobuf source generation through the shared Gradle task-dependency configuration, removing the need for equivalent wiring in consumer modules.

Changes:

• Adds lazy dependencies for main, test, and test-fixtures KSP tasks on their corresponding Protobuf generation tasks.
• Adds tests covering all three dependencies, task registration after evaluation, and projects without Protobuf tasks.

File	Description
buildSrc/​src/​test/​kotlin/​BuildExtensionsSpec.kt	Tests KSP-to-Protobuf dependencies and optional-task behavior.
buildSrc/​src/​main/​kotlin/​BuildExtensions.kt	Adds the three dependencies and reuses KSP task-name variables.

_{Review effort: Balanced}