Repository navigation
Reword the configureApiDocs KDoc - #837
Merged
Merged
Conversation
Shorten the summary to what the call does, and give the fact that the task is not part of `publish` a sentence of its own. Say the root `publishAllApiDocs` depends on the task only when this module is published, as the KDoc speaks of one module. `migrate-publish-api-docs.sh` adds this KDoc to a consumer's `configureGitHubPages()` it renames, so its copy changes too, as does the expected text in `test-migrate-publish-api-docs.sh`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
configureApiDocs KDoc
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the documentation clarification.
No open issues 🎉
What changed in this PR
Clarifies the configureApiDocs() KDoc and keeps the migration-generated documentation and test expectations synchronized. No executable behavior changes.
Changes:
- Shortens the summary and clarifies the relationship between
publishApiDocs,publishAllApiDocs, andpublish. - Applies identical wording to the migration template and its expected test output.
| File | Description |
|---|---|
scripts/test-migrate-publish-api-docs.sh |
Updates the expected KDoc text. |
scripts/migrate-publish-api-docs.sh |
Updates the KDoc inserted during consumer migrations. |
buildSrc/src/main/kotlin/jvm-module.gradle.kts |
Rewords the source configureApiDocs() KDoc. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewords the KDoc of
configureApiDocs()injvm-module.gradle.ktsafter areview-docspass inbase-librariesflagged it: the summary was wordy, and the second paragraph was a run-on with a negative aside tacked on at the end.Before:
After:
"Only when this module is published" replaces "for the published modules only" because the KDoc speaks of one module. The claims match
PublishApiDocs.kt,PublishAllApiDocs.kt(which depends only on the published projects that have the task), and.github-workflows/publish-api-docs.yml(./gradlew :publishAllApiDocs).Copies kept in sync
scripts/migrate-publish-api-docs.sh(from #817) adds this KDoc, word for word, to a consumer'sconfigureGitHubPages()when it renames the function toconfigureApiDocs(). Its copy changes here too, as does the expected text inscripts/test-migrate-publish-api-docs.sh. Future migrations, such asChordsandChords-Gradle-plugin, will get the new wording. Consumers that already migrated (base-libraries,testlib) keep their copy until someone edits it.Checks
scripts/test-migrate-publish-api-docs.sh: 43/43 PASS. That covers adding the KDoc only to a function that has none, and a second run that changes nothing. With the script's heredoc copy alone mutated, 3 checks fail, so the test catches drift between the copies../gradlew :buildSrc:test detekt: BUILD SUCCESSFUL. config's root project has nobuildtask, anddokkaGenerateis not registered.shellcheckon both scripts: clean.pre-pr: PASS.review-docs,spine-code-review, andkotlin-engineerall returned APPROVE. The version gate does not apply, as config has noversion.gradle.kts.🤖 Generated with Claude Code