Repository navigation
Say what a shared TestKit home saves - #833
Merged
Merged
Conversation
The worker builds generate no Gradle API JARs and download few files. Their Gradle user home mostly holds the instrumented JARs of the plugin classpath. Also say that a pull request run finds the directory warm only after a run on the default branch has saved it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also say that only runs on the default branch save the directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the KDoc clarification of shared TestKit cache contents and CI reuse.
No open issues 🎉
What changed in this PR
Corrects the SHARED_TESTKIT_HOME KDoc introduced in #831 to explain what the shared TestKit directory caches and when CI runs can reuse it. No runtime behavior changes.
Changes:
- Identifies Gradle-instrumented plugin classpath JARs and compiled test-project build scripts as the main cached content.
- Clarifies that pull request runs start warm only after a default-branch run saves the cache.
- Removes the inaccurate claim that
setup-gradlepreserves onlycaches/.
| File | Description |
|---|---|
buildSrc/src/main/kotlin/io/spine/gradle/testing/TestKitCoverage.kt |
Corrects KDoc describing shared TestKit cache contents and CI reuse. |
Review effort: Balanced
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the KDoc of
SHARED_TESTKIT_HOME, which #831 added. No behaviour changes.tool-base's tests has no generated Gradle API JARs, and only 12 downloaded files (13 MB). Most of it is Gradle's instrumented copies of the JARs on the classpath of the plugin under test (198 MB of transforms, such as the Kotlin Gradle plugin), plus the test projects' compiled build scripts (36 MB). The KDoc now says so, naming Gradle's instrumentation so that it is not read as JaCoCo's.setup-gradlesaves entries only on the default branch, so a pull request run finds the directory warm only after such a run has saved it. The KDoc now says that too, and drops the claim thatcaches/is the only part of the Gradle user home the action keeps: it keeps the wrapper distributions as well.#831's description repeats the old claim in its "Why" and "First cold run" bullets. The same correction for
plugin-testlib's KDoc is in SpineEventEngine/tool-base#207.Test plan
./gradlew :buildSrc:build detektreview-docs: approved with changes; its findings are applied.🤖 Generated with Claude Code