Repository navigation
Detect Hugo configs in the _preview/ sub-tree - #53
Merged
Merged
Conversation
`check-links` (step 0) and `pre-pr` detected a Hugo site only by a config directly in `docs/` or `site/`, or in their `config/` or `config/_default/`. SpineEventEngine/validation keeps its only Hugo config in `docs/_preview/hugo.toml`, so both skills treated it as having no site: `check-links` approved without checking, and `pre-pr` never dispatched it. The same config paths now also count under the site's `_preview/` sub-tree. This mirrors the matching fix to the "Detect docs site" step of `check-links.yml` in SpineEventEngine/config. The `WORK_DIR` logic is unchanged: `docs/_preview/package-lock.json` already makes it `docs/_preview`. Checked by running the step 0 snippet, before and after, against validation at c72021e (before: "no Hugo documentation site"; after: `SITE_DIR=docs WORK_DIR=docs/_preview`), documentation at 3f69c93 (`docs/_preview` both times), and fixtures for the other layouts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the update extending Hugo configuration detection to _preview/ paths.
No open issues 🎉
What changed in this PR
This PR updates the shared link-checking skills to recognize Hugo sites whose configuration exists only under _preview/, preventing those sites from being skipped.
Changes:
- Extend
check-linksdetection to include the supported Hugo config paths under_preview/. - Align the
pre-prdetection rule with those paths while leaving work-directory selection unchanged.
| File | Description |
|---|---|
skills/pre-pr/SKILL.md |
Expands the Hugo-site rule to include _preview/ configurations. |
skills/check-links/SKILL.md |
Adds _preview/ config paths to the detection snippet and explains their purpose. |
Review effort: Balanced
alexander-yevsyukov
added a commit
to SpineEventEngine/config
that referenced
this pull request
Nov 2, 2026
Brings in SpineEventEngine/agents#53, the skill side of this PR: the `check-links` skill (step 0) and the `pre-pr` "Hugo site" rule now also find a Hugo config in the site's `_preview/` sub-tree, as the "Detect docs site" step of `check-links.yml` does. Also brings in #52 (Dart Sass in the `check-links` tool requirements) and #51 (no trailing `//` after a one-paragraph proto doc comment). Every hook script wired in `.claude/settings.json` and `.codex/hooks.json` is still present and executable at `01b89c3`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 0 of
check-linksand the "Hugo site" rule ofpre-prdetected a Hugo site only by a config directly indocs/orsite/, or in theirconfig/orconfig/_default/. SpineEventEngine/validation keeps its only Hugo config indocs/_preview/hugo.toml. Both skills treated it as having no site:check-linksapproved without checking anything, andpre-prnever dispatched it.Change
skills/check-links/SKILL.md, step 0: the same config paths now also count under$dir/_preview/. TheWORK_DIRlogic is unchanged.skills/pre-pr/SKILL.md: the "Hugo site" rule says the same.This mirrors the fix to the "Detect docs site" step of
check-links.ymlin SpineEventEngine/config#827. The skill says its step 0 mirrors that step.Verification
I ran the step 0 snippet, before and after this change:
c72021eSITE_DIR=docs WORK_DIR=docs/_preview3f69c93SITE_DIR=docs WORK_DIR=docs/_previewdocs/hugo.tomlwithdocs/package-lock.jsonWORK_DIR=docssite/_preview/config/_default/hugo.yamlwith a lockfileSITE_DIR=site WORK_DIR=site/_previewdocs/_preview/hugo.toml, no lockfileERROR: No package-lock.json …(exit 1)🤖 Generated with Claude Code