Repository navigation
Get theme updates and move the styles to @use
#564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
43ce2fb
Get theme updates
alexander-yevsyukov f835662
Bump source-map-js from 1.2.1 to 1.2.2 in /site
dependabot[bot] 250a6ea
Bump postcss-selector-parser and @fullhuman/postcss-purgecss in /site
dependabot[bot] bec4c6f
Move the styles from `@import` to `@use`
alexander-yevsyukov 008a9b3
Replace deprecated Sass functions
alexander-yevsyukov 244ba11
Add task doc for the Dart Sass styles
alexander-yevsyukov eae2f6d
Point the Gitter link to where Gitter redirects
alexander-yevsyukov 424ffd9
Ignore links broken in the imported docs
alexander-yevsyukov 00d6795
Log the link check in the task doc
alexander-yevsyukov 745f1b0
Run Check Links when `.lycheeignore` changes
alexander-yevsyukov 3422c21
Update `config`
alexander-yevsyukov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| slug: dart-sass-site-styles | ||
| branch: get-theme-updates-dart-sass | ||
| owner: claude | ||
| status: in-review | ||
| started: 2026-10-30 | ||
| --- | ||
|
|
||
| ## Goal | ||
|
|
||
| The site builds on the Dart Sass `site-commons` theme, and its own styles use | ||
| the Sass module system, so `hugo --minify` prints no Sass warnings and the CSS | ||
| stays the same. | ||
|
|
||
| ## Context | ||
|
|
||
| - SpineEventEngine/site-commons#38 — move the theme and its sites from LibSass | ||
| to Dart Sass. Hugo deprecated LibSass in v0.153.0; Dart Sass 3.0 removes `@import`. | ||
| - The theme update brings in site-commons#39 (jQuery served as a file), #40 | ||
| (Dart Sass) and #41 (`@use`/`@forward`). `theme-main.scss` forwards the theme | ||
| and Bootstrap, so `@use "theme-main" as *;` gives a partial what `@import` did. | ||
| - Hugo sets `silenceDependencyDeprecations`, which hides deprecations in every | ||
| file except the entry one. The `sass` CLI with `--verbose` shows them all. | ||
| - Also folds in the Dependabot bumps of #558 (`source-map-js`) and #560 | ||
| (`postcss-selector-parser`, `@fullhuman/postcss-purgecss` 8). Nothing loads | ||
| PurgeCSS; the CSS is byte-identical with and without them. | ||
|
|
||
| ## Plan | ||
|
|
||
| - [x] `hugo mod get -u github.com/SpineEventEngine/site-commons` in `site/`. | ||
| - [x] Cherry-pick the bumps from #558 and #560. | ||
| - [x] `main.scss` and its partials: `@import` → `@use`, in the same order. | ||
| - Partials that use theme or Bootstrap members: `@use "theme-main" as *;`. | ||
| - Partials that use another partial's members `@use` it by a relative path: | ||
| `base/colors` (variables), `base/common` (`%expandable-title`) and | ||
| `modules/forms` (`$form-error-color`). `main.scss` loads each of them | ||
| before its users, so no CSS moves. | ||
| - [x] `map-get()` → `map.get()`, `fade-out()` → `color.adjust($alpha: …)`. | ||
| - [x] Verify: Sass warnings, and the CSS rule by rule against the previous build. | ||
| - [x] Keep Check Links passing. With jQuery no longer inlined (site-commons#39), | ||
| Lychee reads whole pages and finds 14 links that were already broken. | ||
| - Point the Gitter link of the 1.0 blog post to where Gitter redirects. | ||
| - `.lycheeignore` lists the 13 broken in the imported docs, as in | ||
| SpineEventEngine/documentation#96. | ||
|
|
||
| ## Log | ||
|
|
||
| - 2026-10-30 — theme update: the only Sass warnings left are the 28 `@import`s | ||
| in `main.scss`. CSS differences are Dart Sass formatting and precision, folded | ||
| `calc()`, the code-tab indicator's `border-radius: 1px`, no `@extend`ed | ||
| `.h1`–`.h6`/`.small`/`.mark` selectors (no page uses them), and the medium | ||
| Roboto Mono `.eot` now pointing to `fonts/robotomono/` (site-commons#41). | ||
| - 2026-10-30 — `@use` move: `hugo --minify` prints no Sass warnings. The `sass` | ||
| CLI reports 52 fewer deprecations (382 → 330), all the site's own; the rest | ||
| come from Bootstrap. The CSS has the same 12,764 declarations; one | ||
| `@extend`ed selector list lists its two selectors in the other order. | ||
| - 2026-10-30 — the CSS now starts with the theme's license comment instead of | ||
| Bootstrap's. `@use "theme-main"` emits that file's `/*!` header first, and | ||
| the theme's PostCSS step keeps only the first comment. To fix in `site-commons`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Lychee skips the URLs matching these patterns. It reads this file from the | ||
| # directory it runs in, the repository root. `lychee.toml` comes from `config` | ||
| # and `./config/pull` overwrites it, so links specific to this site go here. | ||
| # | ||
| # Remove a pattern once the module update that fixes its link lands here. | ||
|
|
||
| # Broken in the docs of `SpineEventEngine/documentation`, which | ||
| # `site/config/_default/hugo.toml` imports as a module. Fixed by | ||
| # https://github.com/SpineEventEngine/documentation/pull/96. | ||
| ^https://stackoverflow\.com/a/31814967/3183076$ | ||
|
|
||
| # Broken in the docs of `SpineEventEngine/validation`, which come in through | ||
| # `SpineEventEngine/documentation`, so they can only be fixed there. | ||
| # See https://github.com/SpineEventEngine/documentation/issues/97. | ||
| ^https://github\.com/SpineEventEngine/validation/blob/master/\.agents/running-builds\.md$ | ||
| ^https://github\.com/SpineEventEngine/validation/blob/master/\.agents/documentation-guidelines\.md$ | ||
| ^https://github\.com/SpineEventEngine/embed-code-go/blob/master/EMBEDDING\.md$ | ||
| ^https://github\.com/SpineEventEngine/embed-code-go/tree/master/bin$ | ||
| ^https://plugins\.gradle\.org/plugin/io\.spine\.validation$ | ||
| # Relative links that resolve outside the module's pages. | ||
| ^http://localhost:[0-9]+/06-developers-guide/$ | ||
| ^http://localhost:[0-9]+/developer/$ | ||
| ^http://localhost:[0-9]+/typical_custom_option\.jpg$ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.