Repository navigation
Move the CVD Policy to the Security section of the documentation - #554
Conversation
The Coordinated Vulnerability Disclosure Policy now lives in the `documentation` repository, under Documentation > Security, at `/docs/security/cvd-policy/` (SpineEventEngine/documentation#88). - Pin the `documentation` module to the head of that pull request, which brings the Security section. This also raises `validation/docs` to the version `documentation` requires. - Remove the old page and add a static redirect from `/cvd-policy/`. GitHub Pages cannot send HTTP redirects, so the page redirects in the browser. Its URLs are site-relative, so the link check follows them to the local build rather than to the live site. `SECURITY.md` and other sites link to `/cvd-policy/`, so the redirect is to stay. - Point the footer link and the `Policy` field of `security.txt` to the new URL, and fix its `Expires` value: a stray space made the timestamp invalid under RFC 9116. - Let the docs layout honour `has_numbered_headings`, as the privacy layout does, so the moved policy keeps its numbered sections. - Fix the numbered table of contents: the number lacked `position: absolute`, so it took space next to the padding meant to hold it, leaving a wide gap and misaligning titles that wrap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Security policy page fetches `SECURITY.md` from `SpineEventEngine/.github` when the site is built. - Expire fetched files after an hour. Hugo never expires them by default, and the `check-links` workflow restores the Hugo cache between runs, so it would keep serving the first copy. - Allow running the deploy by hand, from `master` only, to publish a change to `SECURITY.md` without a commit here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34673e2fe6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A deploy, manual ones included, must publish the current `SECURITY.md`. With the one-hour expiry, a deploy that restored a Hugo cache would publish a copy up to an hour old. The deploy workflow doesn't restore the Hugo cache today, since Hugo doesn't use the directory it caches, but that is an accident of paths rather than a guarantee. Production builds now keep no fetched files at all. Development builds, including the link check, keep them for an hour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM except for a single comment to discuss.
There was a problem hiding this comment.
This whole file looks suspicious. Let's discuss.
The site side of the new Documentation → Security section, added in SpineEventEngine/documentation#88. The Coordinated Vulnerability Disclosure Policy moves from
/cvd-policy/to/docs/security/cvd-policy/, next to the new Security policy and Verifying artifacts pages.What changed
documentationis pinned to the head of Add style for quotes #88 (1d7c3e1). MVS also raisesvalidation/docsfrom 2026-05-22 to 2026-05-23, the versiondocumentationrequires.go.sumonly gains the four lines the bump needs; no tidy.site/static/cvd-policy/index.htmlredirects to the new page.meta refreshpage withrel=canonicalandnoindex, like the ones Hugo generates foraliases./cvd-policyto/cvd-policy/.SECURITY.mdand outside sites link to/cvd-policy/, so the redirect must stay.Policy:field ofsecurity.txtpoint to the new URL.security.txtalso gets itsExpires:fixed:2027-09-10 T13:05…had a stray space, which makes it an invalid RFC 9116 timestamp.layouts/docs/single.htmlnow honourshas_numbered_headings, aslayouts/privacy/single.htmldoes, so the moved policy keeps its numbered sections._numbered-headings.scss): the#TableOfContentsrules never ran before, because no page had put a TOC inside.numbered-headings. The number lackedposition: absolute, so it took 30px next to the link's 42px padding instead of sitting inside it. That caused a wide gap, and the flex item shrank on titles that wrap, misaligning them. Two declarations fix it.SECURITY.md(second commit): the Security policy page fetchesSECURITY.mdfromSpineEventEngine/.githubat build time.check-linksrestores the Hugo cache between runs.gh-pages.ymlgets aworkflow_dispatchtrigger, guarded to deploy only frommaster, so aSECURITY.mdchange can be published without a commit here.Merge order
Merge SpineEventEngine/documentation#88 first. The pin points to that PR's head commit. If #88 gets new commits before it merges, this pin needs a matching bump. Once #88 merges with a merge commit,
1d7c3e1stays reachable frommaster.Verification
hugo -e development): no errors; the three Security pages, the redirect and the numbered headings are all present.documentationcheckout:/cvd-policyand/cvd-policy/both reach the new page;Policy:URL insecurity.txt, which the CI check doesn't scan (it scans*.html) and which resolves once this deploys.🤖 Generated with Claude Code