Repository navigation
fix(deploy): target sonicjs-client-directory Pages project for client.sonicjs.com - #1219
Conversation
client.sonicjs.com is served by the sonicjs-client-directory Pages project (last deployed 1 year ago), not sonicjs-sdk-demo. Deploying to the wrong project left the live site on a stale 1-year-old build.
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
PR Summary by QodoDeploy the employee directory to the Pages project serving client.sonicjs.com
AI Description
Merge Risk
|
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
Code Review by Qodo
1. Local demo deploy script still targets the stale project
|
|
|
||
| - name: Deploy to Cloudflare Pages | ||
| run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-sdk-demo --branch main | ||
| run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-client-directory --branch main |
There was a problem hiding this comment.
Manual deploys still target elsewhere
package.json keeps deploy:demo pointed at sonicjs-sdk-demo, while this workflow now targets sonicjs-client-directory. Developers running npm run deploy:demo still publish to the old project and leave client.sonicjs.com unchanged. Update the manual command alongside this workflow so both deploy paths reach the same site.
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- The root
package.jsonmanualdeploy:demoscript still targets the old project, so running it can push a stale demo. Update it tosonicjs-client-directory.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/deploy-demo.yml">
<violation number="1" location=".github/workflows/deploy-demo.yml:46">
P3: The manual `deploy:demo` script in the root `package.json` still targets `sonicjs-sdk-demo`, the project this PR stops using. Update it to `sonicjs-client-directory` too, or a manual run will push the stale target again.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
|
||
| - name: Deploy to Cloudflare Pages | ||
| run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-sdk-demo --branch main | ||
| run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-client-directory --branch main |
There was a problem hiding this comment.
P3: The manual deploy:demo script in the root package.json still targets sonicjs-sdk-demo, the project this PR stops using. Update it to sonicjs-client-directory too, or a manual run will push the stale target again.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/deploy-demo.yml, line 46:
<comment>The manual `deploy:demo` script in the root `package.json` still targets `sonicjs-sdk-demo`, the project this PR stops using. Update it to `sonicjs-client-directory` too, or a manual run will push the stale target again.</comment>
<file context>
@@ -43,7 +43,7 @@ jobs:
- name: Deploy to Cloudflare Pages
- run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-sdk-demo --branch main
+ run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-client-directory --branch main
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
</file context>
Codex ReviewVerdict: Comment (1 minor finding, non-blocking) The core change ( 🟡 P2 — Keep local and CI demo targets aligned
So a manual/local deploy via that script would push to a different Cloudflare Pages project than CI now does. If the split is intentional, consider a comment noting why; otherwise update the script to match. No security concerns — single-line config change, no secrets/logic touched. Reviewed by Codex (codex-auto-review) via Hermes Agent |
Root cause
client.sonicjs.comis served by thesonicjs-client-directoryCloudflare Pages project (confirmed viawrangler pages project list), notsonicjs-sdk-demo. The workflow has been deploying to the wrong project, leaving the live site on a 1-year-old build.Fix
Change
--project-name sonicjs-sdk-demo→--project-name sonicjs-client-directoryindeploy-demo.yml.Summary by cubic
Fixes the deployment workflow so
client.sonicjs.comreceives current builds. The workflow was deploying to thesonicjs-sdk-demoCloudflare Pages project, but the site is served bysonicjs-client-directory, leaving the live site on a stale 1-year-old build. The deploy command now targetssonicjs-client-directory.Written for commit 4881999. Summary will update on new commits.
The workflow change appears safe to merge, with a non-blocking follow-up to align the manual deploy command.
Findings
Summary
Changes the demo workflow to deploy to
sonicjs-client-directory, the Pages project identified in the PR as servingclient.sonicjs.com.client.sonicjs.com.Reviews (1) · Last reviewed commit: "fix(deploy): target sonicjs-client-direc..." · Reviewed by Greptile