Skip to content

fix(deploy): target sonicjs-client-directory Pages project for client.sonicjs.com - #1219

Merged
lane711 merged 1 commit into
mainfrom
fix/deploy-correct-pages-project
Nov 20, 2026
Merged

lane711 merged 1 commit into
mainfrom
fix/deploy-correct-pages-project

Conversation

@lane711

@lane711 lane711 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Root cause

client.sonicjs.com is served by the sonicjs-client-directory Cloudflare Pages project (confirmed via wrangler pages project list), not sonicjs-sdk-demo. The workflow has been deploying to the wrong project, leaving the live site on a 1-year-old build.

Fix

Change --project-name sonicjs-sdk-demo → --project-name sonicjs-client-directory in deploy-demo.yml.


Summary by cubic

Fixes the deployment workflow so client.sonicjs.com receives current builds. The workflow was deploying to the sonicjs-sdk-demo Cloudflare Pages project, but the site is served by sonicjs-client-directory, leaving the live site on a stale 1-year-old build. The deploy command now targets sonicjs-client-directory.

Written for commit 4881999. Summary will update on new commits.

View guided diff Turn on auto-fix

RetriggerView in GreptileConfidence Score: 4/5

The workflow change appears safe to merge, with a non-blocking follow-up to align the manual deploy command.

Findings

  1. P2 Manual deploys still target elsewhere ▶

Summary

Changes the demo workflow to deploy to sonicjs-client-directory, the Pages project identified in the PR as serving client.sonicjs.com.

  • The demo workflow sends its Pages upload to the project serving client.sonicjs.com.

Reviews (1) · Last reviewed commit: "fix(deploy): target sonicjs-client-direc..." · Reviewed by Greptile

client.sonicjs.com is served by the sonicjs-client-directory Pages
project (last deployed 1 year ago), not sonicjs-sdk-demo.  Deploying
to the wrong project left the live site on a stale 1-year-old build.
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Deploy the employee directory to the Pages project serving client.sonicjs.com

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Target sonicjs-client-directory instead of sonicjs-sdk-demo in the deployment workflow.
• Restore deployments to the project serving client.sonicjs.com, which has remained on an old
 build.
Merge Risk 🟢 Low

Blast radius 🟢 Low 💥 1 capability

  • 1 affected end-to-end capability after fault-specific containment; implementation boundaries do not widen its functional scope.
  • The changed command publishes the built employee-directory demo as one bounded end-to-end demonstration capability.
  • The workflow build and Cloudflare Pages target are deployment hops of that same user-facing demo, not independent capabilities or scopes.
Behavioral complexity 🟢 Low 🧩 Straightforward

  • Before: the workflow mapped the built demo artifact to the sonicjs-sdk-demo Pages project.
  • After: it maps the same artifact to sonicjs-client-directory.
  • The changed correctness condition is a direct deployment-target mapping: the configured project must be the intended existing Pages project and accept the workflow credentials.
  • No new branches, state machine, data transformation, concurrency protocol, migration, or coordinated invariant is introduced in the changed logic.
Potential damage 🟡 Medium 🩹 Temporary loss

  • A bad or unauthorized target can prevent the updated demo from being published, causing temporary loss of access to the updated demonstration or leaving users on an older version.
  • Reverting the workflow line restores the former routing, but the missed deployment still requires a rerun.
  • If a wrong project accepts the upload, correction also requires identifying and redeploying the intended project.
  • There is no evidence of persistent application-state corruption or external financial/data effects.
  • Recoverable by correcting the Pages project configuration or credentials and rerunning the workflow; code rollback alone does not repair a missed deployment until a successful deployment is executed.
  • Existing deployed content may remain available during recovery.
Assessed commit 4881999
High-Level Assessment

Changing the deployment target directly is appropriate because the build and deployment flow remain valid; only the Pages project name was wrong.

Files changed (1) +1 / -1

Bug fix (1) +1 / -1
deploy-demo.ymlTarget the Pages project serving client.sonicjs.com +1/-1

Target the Pages project serving client.sonicjs.com

• Changes the employee-directory deployment command to publish to 'sonicjs-client-directory' instead of 'sonicjs-sdk-demo'. The build output, branch, and credentials are unchanged.

.github/workflows/deploy-demo.yml

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the deployment destination for the employee directory demo. Its deployment path and main branch remain unchanged.

The deploy-demo workflow now targets the Cloudflare Pages project sonicjs-client-directory instead of sonicjs-sdk-demo. The deployment directory and branch are unchanged.

Changes: Demo deployment

Layer / File(s) Summary
Cloudflare Pages target
.github/workflows/deploy-demo.yml
The workflow now deploys to the sonicjs-client-directory project. The deployment directory and branch are unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • SonicJs-Org/sonicjs#1215: This PR changes the same workflow and deployment path, including build steps that are present in the current workflow.
Merge Risk: Minimal · up to 48819

This change points the demo deployment workflow at the Cloudflare Pages project that serves client.sonicjs.com, so the live site should update on the next deploy. The only remaining uncertainty is whether the existing Cloudflare credentials can deploy to the new project, which the first run will show.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: the deploy-demo workflow now targets the sonicjs-client-directory Cloudflare Pages project for client.sonicjs.com. It matches the single-line change in deploy-demo.yml. The…
Description check Passed The description follows the template's main idea. It gives a root cause and a fix, and it names the file and the change. It omits the template's Changes list, Testing checkboxes, Screenshots section, …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: the deploy-demo workflow now targets the sonicjs-client-directory Cloudflare Pages project for client.sonicjs.com. It matches the single-line change in deploy-demo.yml. The 81-character length is slightly long but still clear and specific.

Full details: Description check

Explanation

The description follows the template's main idea. It gives a root cause and a fix, and it names the file and the change. It omits the template's Changes list, Testing checkboxes, Screenshots section, and Checklist, and it does not reference an issue in the 'Fixes #' line. Most required content is present, so the check passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 68f9ba78-4b1f-49b8-b382-e878252f6209
Commits

Reviewing files that changed from the base of the PR and between e51884d and 4881999.

Files selected for processing: 1

  • .github/workflows/deploy-demo.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1)

Grey Divider


Remediation recommended

1. Local demo deploy script still targets the stale project 🐞 Bug
Description
The deploy:demo script in the root package.json still passes --project-name sonicjs-sdk-demo,
the same Pages project this PR removes from the CI workflow. Running npm run deploy:demo by hand
therefore keeps publishing to the project that does not serve client.sonicjs.com, so the live site
stays on the old build.
Code

.github/workflows/deploy-demo.yml[46]

+        run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-client-directory --branch main

Grey Divider

Tip of the day
💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo


- name: Deploy to Cloudflare Pages
run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-sdk-demo --branch main
run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-client-directory --branch main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Manual deploys still target elsewhere

package.json keeps deploy:demo pointed at sonicjs-sdk-demo, while this workflow now targets sonicjs-client-directory. Developers running npm run deploy:demo still publish to the old project and leave client.sonicjs.com unchanged. Update the manual command alongside this workflow so both deploy paths reach the same site.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 4/5

  • The root package.json manual deploy:demo script still targets the old project, so running it can push a stale demo. Update it to sonicjs-client-directory.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/deploy-demo.yml">

<violation number="1" location=".github/workflows/deploy-demo.yml:46">
P3: The manual `deploy:demo` script in the root `package.json` still targets `sonicjs-sdk-demo`, the project this PR stops using. Update it to `sonicjs-client-directory` too, or a manual run will push the stale target again.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic


- name: Deploy to Cloudflare Pages
run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-sdk-demo --branch main
run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-client-directory --branch main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The manual deploy:demo script in the root package.json still targets sonicjs-sdk-demo, the project this PR stops using. Update it to sonicjs-client-directory too, or a manual run will push the stale target again.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/deploy-demo.yml, line 46:

<comment>The manual `deploy:demo` script in the root `package.json` still targets `sonicjs-sdk-demo`, the project this PR stops using. Update it to `sonicjs-client-directory` too, or a manual run will push the stale target again.</comment>

<file context>
@@ -43,7 +43,7 @@ jobs:
 
       - name: Deploy to Cloudflare Pages
-        run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-sdk-demo --branch main
+        run: npx wrangler pages deploy demos/employee-directory/dist --project-name sonicjs-client-directory --branch main
         env:
           CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
</file context>

@lane711

lane711 commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Codex Review

Verdict: Comment (1 minor finding, non-blocking)

The core change (--project-name sonicjs-sdk-demo → sonicjs-client-directory in .github/workflows/deploy-demo.yml) correctly targets the Pages project that serves client.sonicjs.com.

🟡 P2 — Keep local and CI demo targets aligned

.github/workflows/deploy-demo.yml:46
This PR updates only the CI workflow. The root deploy:demo npm script in package.json:24 still points at sonicjs-sdk-demo:

"deploy:demo": "cd demos/employee-directory && npm run build && npx wrangler pages deploy dist --project-name sonicjs-sdk-demo --branch main"

So a manual/local deploy via that script would push to a different Cloudflare Pages project than CI now does. If the split is intentional, consider a comment noting why; otherwise update the script to match.

No security concerns — single-line config change, no secrets/logic touched.


Reviewed by Codex (codex-auto-review) via Hermes Agent

@lane711
lane711 merged commit 9c343c3 into main Nov 20, 2026
16 of 20 checks passed

This branch was previously deployed

1 inactive deployment
internal — 48819998 Deployed Nov 20, 2026 by lane711 via authorize #2125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant