Skip to content

add in missing legacy - first issuer default fallback - #867

Merged
SharonStrats merged 3 commits into
stagingfrom
fix/login-default
Sep 9, 2026
Merged

add in missing legacy - first issuer default fallback#867
SharonStrats merged 3 commits into
stagingfrom
fix/login-default

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

the old login pop up also had a fall back to default to the first issuer in the list if there wasn't one in the localStorage.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

src/login/login.ts still accesses localStorage without the defensive guard used elsewhere, which can cause runtime failures outside fully browser-like environments.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the login UI components to default the issuer input to the first solid-logic suggested issuer when no previously-used issuer is present in storage and no explicit issuer URL is provided.

Changes:

  • Add a fallback default issuer (getSuggestedIssuers()[0]?.uri) in the v2 LoginButton popup flow.
  • Add the same fallback default issuer in the legacy renderSignInPopup issuer text input.
  • Add the same fallback default issuer in the LoginModal web component initialization.
File summaries
File Description
src/v2/components/auth/loginButton/LoginButton.ts Adds suggested-issuer fallback when opening the login popup.
src/login/login.ts Defaults the legacy issuer text input to the first suggested issuer when no stored issuer exists.
src/components/login-modal/LoginModal.ts Initializes modal issuer input with a suggested-issuer fallback.
Review details
  • Files reviewed: 3/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/login/login.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@SharonStrats SharonStrats changed the title add in missing legacy first issuer default add in missing legacy - first issuer default fallback Sep 9, 2026
@SharonStrats
SharonStrats merged commit f8d7b3c into staging Sep 9, 2026
9 checks passed
@SharonStrats
SharonStrats deleted the fix/login-default branch September 9, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants