Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
`CITATION.cff` gains `email: jroach@isbscience.org` on the third author, so
the private security-report pathway `CONTRIBUTING.md` points at ("Email the
maintainers listed in `CITATION.cff`") reaches all three maintainers. The
contributor lists in `README.md` and `docs/index.md` and the enforcement
contacts in `CODE_OF_CONDUCT.md` link his address like the other two.
Co-authored-by: Jared C. Roach <7597293+jaredroach@users.noreply.github.com>
SkyeAv
force-pushed
the
add-jared-orcid
branch
from
October 5, 2026 18:12
acc5445 to
a84bd59
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jared C. Roach is the third author in
CITATION.cffand the third name in the README and docscontributor lists, but his entry carried no email while the other two did. This adds
jroach@isbscience.orgeverywhere Skye's and Gwenlyn's addresses already appear as links.Contact metadata
CITATION.cff:email: jroach@isbscience.orgon the third author, in the same field order asthe entries above it (
given-names,family-names,email,affiliation,orcid). This is morethan symmetry:
CONTRIBUTING.mdroutes private security reports to "the maintainers listed inCITATION.cff", which named only two reachable addresses before this change.README.mdanddocs/index.md: the Contributors and Authors lists link his address, matchingthe
mailto:style already used for the other two names.CODE_OF_CONDUCT.md: the enforcement sentence now names all three contacts, which keepsCONTRIBUTING.md's "the enforcement contacts named there" and the 19.5.1 changelog claim that thecode of conduct "names the
CITATION.cffmaintainer emails as enforcement contacts" true for thewhole author list.
Design
jroach@isbscience.orgfollows ISB'sfirst-initial-plus-surname convention (
sgoetz,gglusman) and was supplied by the maintainer; nopublic source I could reach publishes it (Europe PMC full text and GitHub code search return zero
hits for the literal string, and his ORCID record publishes no email). What the ORCID public API
does confirm is the affiliation already in
CITATION.cff:0000-0003-4524-0107, "Senior ResearchScientist, Institute for Systems Biology", start 2001, no end date.
pyproject.tomlleft alone. Itsauthorsarray lists only Skye, and not Gwenlyn either, soadding a third name there would change packaging metadata rather than restore parity. Say the word
and I will add all three in a follow-up.
CHANGELOG.mdentry, matching docs: overhaul documentation for external readers #205, docs: add a Contributor Covenant code of conduct #206, and docs: add verified ORCIDs and a factual abstract to CITATION.cff #207, whose docs entries werewritten by the release commit (
08bf9ba) rather than by the PR.Testing
uvx cffconvert -i CITATION.cff --validate->Citation metadata are valid according to schema version 1.2.0.CITATION.cff-> three authors, each withemailandorcidpopulated.pytest tests/test_docs_source_of_truth.py -q --no-cov->201 passed in 6.55s. That suite guardsREADME/docs nav parity and every fenced config block; the new links live in the Contributors and
Authors lists, not the Documentation lists.
uv sync --frozen --no-default-groups --group docs --no-install-projectthenuv run --no-sync mkdocs build --strict->Documentation built in 0.46 seconds, no warnings, andthe built
site/index.htmlcontainsjroach@isbscience.org.ruff,pyright,pytest, andcargoCI jobs have nothing newto exercise.
Questions for the reviewer
leader for conduct reports. Revert the
CODE_OF_CONDUCT.mdhunk if that is not intended; the otherthree files are pure contact metadata.
Authorship
Co-authored-by: Jared C. Roach <7597293+jaredroach@users.noreply.github.com>,the same mechanism the docs commits in docs: add a Contributor Covenant code of conduct #206 and docs: add verified ORCIDs and a factual abstract to CITATION.cff #207 use for Gwenlyn, so he is credited on the
squash-merged commit and appears as a contributor. The account is
jaredroach(id7597293),whose GitHub profile lists the name Jared Roach and the company Institute for Systems Biology,
which commits to
glusman-team/MOKGConfigurationand watches this repo.jaredroachwith write access, matchinggglusman's standing (invitation336221718, created 2026-10-05). GitHub delivers it to theemail bound to his GitHub account; once he accepts, a review request on this PR can be added
(GitHub only allows review requests from accepted collaborators, so it will land after
acceptance rather than before).