Skip to content

docs: add Jared Roach's email to the maintainer contact lists - #210

Open
SkyeAv wants to merge 1 commit into
mainfrom
add-jared-orcid
Open

SkyeAv wants to merge 1 commit into
mainfrom
add-jared-orcid

Conversation

@SkyeAv

@SkyeAv SkyeAv commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Jared C. Roach is the third author in CITATION.cff and the third name in the README and docs
contributor lists, but his entry carried no email while the other two did. This adds
jroach@isbscience.org everywhere Skye's and Gwenlyn's addresses already appear as links.

Contact metadata

  • CITATION.cff: email: jroach@isbscience.org on the third author, in the same field order as
    the entries above it (given-names, family-names, email, affiliation, orcid). This is more
    than symmetry: CONTRIBUTING.md routes private security reports to "the maintainers listed in
    CITATION.cff", which named only two reachable addresses before this change.
  • README.md and docs/index.md: the Contributors and Authors lists link his address, matching
    the mailto: style already used for the other two names.
  • CODE_OF_CONDUCT.md: the enforcement sentence now names all three contacts, which keeps
    CONTRIBUTING.md's "the enforcement contacts named there" and the 19.5.1 changelog claim that the
    code of conduct "names the CITATION.cff maintainer emails as enforcement contacts" true for the
    whole author list.

Design

  • The address is not independently verifiable. jroach@isbscience.org follows ISB's
    first-initial-plus-surname convention (sgoetz, gglusman) and was supplied by the maintainer; no
    public source I could reach publishes it (Europe PMC full text and GitHub code search return zero
    hits for the literal string, and his ORCID record publishes no email). What the ORCID public API
    does confirm is the affiliation already in CITATION.cff: 0000-0003-4524-0107, "Senior Research
    Scientist, Institute for Systems Biology", start 2001, no end date.
  • pyproject.toml left alone. Its authors array lists only Skye, and not Gwenlyn either, so
    adding a third name there would change packaging metadata rather than restore parity. Say the word
    and I will add all three in a follow-up.
  • Deferred: no CHANGELOG.md entry, matching docs: overhaul documentation for external readers #205, docs: add a Contributor Covenant code of conduct #206, and docs: add verified ORCIDs and a factual abstract to CITATION.cff #207, whose docs entries were
    written by the release commit (08bf9ba) rather than by the PR.

Testing

  • uvx cffconvert -i CITATION.cff --validate -> Citation metadata are valid according to schema version 1.2.0.
  • PyYAML parse of CITATION.cff -> three authors, each with email and orcid populated.
  • pytest tests/test_docs_source_of_truth.py -q --no-cov -> 201 passed in 6.55s. That suite guards
    README/docs nav parity and every fenced config block; the new links live in the Contributors and
    Authors lists, not the Documentation lists.
  • uv sync --frozen --no-default-groups --group docs --no-install-project then
    uv run --no-sync mkdocs build --strict -> Documentation built in 0.46 seconds, no warnings, and
    the built site/index.html contains jroach@isbscience.org.
  • No Python or Rust changed, so the ruff, pyright, pytest, and cargo CI jobs have nothing new
    to exercise.

Questions for the reviewer

  • Code of conduct enforcement. Naming a third enforcement contact designates Jared as a community
    leader for conduct reports. Revert the CODE_OF_CONDUCT.md hunk if that is not intended; the other
    three files are pure contact metadata.

Authorship

  • The commit carries Co-authored-by: Jared C. Roach <7597293+jaredroach@users.noreply.github.com>,
    the same mechanism the docs commits in docs: add a Contributor Covenant code of conduct #206 and docs: add verified ORCIDs and a factual abstract to CITATION.cff #207 use for Gwenlyn, so he is credited on the
    squash-merged commit and appears as a contributor. The account is jaredroach (id 7597293),
    whose GitHub profile lists the name Jared Roach and the company Institute for Systems Biology,
    which commits to glusman-team/MOKGConfiguration and watches this repo.
  • A repository collaboration invite is also out to jaredroach with write access, matching
    gglusman's standing (invitation 336221718, created 2026-10-05). GitHub delivers it to the
    email bound to his GitHub account; once he accepts, a review request on this PR can be added
    (GitHub only allows review requests from accepted collaborators, so it will land after
    acceptance rather than before).

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 180ab6fd-05f6-46bc-9d52-8d7a49c526e9
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

`CITATION.cff` gains `email: jroach@isbscience.org` on the third author, so
the private security-report pathway `CONTRIBUTING.md` points at ("Email the
maintainers listed in `CITATION.cff`") reaches all three maintainers. The
contributor lists in `README.md` and `docs/index.md` and the enforcement
contacts in `CODE_OF_CONDUCT.md` link his address like the other two.

Co-authored-by: Jared C. Roach <7597293+jaredroach@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant