Repository navigation
Make Gravatar opt-in and pin the Tailwind CDN version - #60
Merged
Merged
Conversation
Gravatar avatars are now behind SIMPLEAUDIT_GRAVATAR (default off); when off, no gravatar.com URL is rendered and templates show the user's initial. The visualizer sidebar uses the same helper. The Tailwind Play CDN script is pinned to 3.4.17, the version cdn.tailwindcss.com currently redirects to.
Document SIMPLEAUDIT_GRAVATAR in both env examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the signed-in user's avatar in the app sidebar, the visualizer sidebar and the profile page is loaded from Gravatar, so the browser sends the MD5 hash of the user's email to gravatar.com without any configuration.
This makes Gravatar opt-in behind
SIMPLEAUDIT_GRAVATAR(default off, documented indocs/deployment.md): when it is off, no Gravatar image URL is rendered, so the browser makes no request to gravatar.com, and the existing fallback shows the user's initial.The Tailwind script tag in
templates/base.html,templates/public/base_public.html,static/visualizer.htmlandstatic/scenario_viewer.htmlnow loadshttps://cdn.tailwindcss.com/3.4.17, the exact version the floatinghttps://cdn.tailwindcss.comURL redirects to today, instead of the floating URL.pytest -n 4 -m "not embedded_hatchet"gave 4 failed, 1286 passed, 2 skipped onmainbefore the change and 4 failed, 1290 passed, 2 skipped after it; the same four agentic tests fail in both runs, and the four added passes are the new tests ininfra/tests/test_gravatar.py.AI disclosure: implemented with Claude Code.