Repository navigation
Only bump files inside the given directory - #1038
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
`spoom srb bump DIRECTORY` selected files with a plain string prefix check, so `spoom srb bump lib/b` also bumped files under `lib/bb/`. Match the directory itself or paths below it instead.
Author
|
I have signed the CLA. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spoom srb bump DIRECTORYfilters files withfile.start_with?(directory). Because the check doesn't require a path separator,spoom srb bump lib/balso bumps files underlib/bb/orlib/b_legacy/.This change keeps a file only if it is
DIRECTORYitself or sits belowDIRECTORY/. Passing a single file path still works.Tests
Added
test_bump_doesnt_change_sigils_in_sibling_directory_with_same_prefix. It fails onmain(Bumped 2 files, includinglib/bb/file.rb) and passes with this change.bin/test test/spoom/cli/srb/bump_test.rbpasses (33 tests), andrubocopandsrb tcare clean.Fixes #1037