Return created/updated objects

Overview

The API itself will already return the full object if you do a create/update operation. However, the library swallows this response here:
https://github.com/Shopify/shopify-php-api/blob/0556edf274ceb83346533bd22b662d7622e58c66/src/Rest/Base.php#L60-L74

Solution

Adding return $response->getDecodedBody(); at the end of the function should suffice. Note that the saveAndUpdate function would also need to be updated, with return $this->save(true);. Implementation can be found in my fork: MagicLegend@d43bc94

Type

New feature
Changes to existing features

Motivation

What inspired this feature request? What problems were you facing?

I would like to verify the saved object myself, without needing to query the API again for data that was already returned in the first place. This also allows immediate access to the ID of the newly created object.

+1
I don't know why this has NOT been implemented yet.

I have created PR for this. This is what should be (save return response, saveAndUpdate update object itself)
#185

This is a pretty serious issues that the Base.php save() method returns void. E.g. the rest api order docs incorrectly state there will be a response. Getting the response with the new order's id is mission critical for our use case, but I don't see a way to access the updated object.

Any contributors able to post a workaround until this is resolved?

@Zelfapp

@Zelfapp Yeah, as stated in the original message, I have fixed this (along with other improvements to the library) in my fork: MagicLegend@d43bc94

@MagicLegend

@MagicLegend I saw your PR. This library has too many issues for a private app at this point and feels too hacky. It has great potential though.

For the sake of anyone else battling this alpha lib for a private app, likely you're better off simply using guzzle to make REST api endpoint requests. E.g. in just few lines of code you can dynamically pass in any endpoint and payload.

Again, this is a great lib, but I would not classify as ready for production.

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Request;

/// Guzzle client
$client = new Client();
$request = new Request(
    'GET',
    "https://$this->shop/admin/api/2022-07/$endpoint",
    [
        'X-Shopify-Access-Token' => $this->permanentAccessToken,
    ],
    $endpointParams['payload'] ?? null,
);
$response = $client->sendAsync($request)->wait();
$response = $response->getBody();

I respectfully disagree, and we have my fork running in production right now. It works fine, it just has some quirks that Shopify is not allocating resources to to solve. I prefer using a library that's providing typing over doing it manually in Guzzle, but both will of course work fine.

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

Still waiting on Shopify...

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

Still waiting on Shopify...

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

Yeah, and why is it stale bot? Because Shopify doesn't reply ;)

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

Yeah, and why is it stale bot? Because Shopify doesn't reply ;)

Hey folks, thanks for your patience here. We've removed the stalebot from this repo, and I'm going to add this issue to our tracking.

Once again, thank you for your patience!

No worries. You can find an implementation of this issue in my fork: MagicLegend@d43bc94

Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-php instead, and open new issues there. More context: Rethinking support for PHP/Python packages

Navigation Menu

Repository navigation

Return created/updated objects #175

Overview

Solution

Type

Motivation

31 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Return created/updated objects #175

Description

Overview

Solution

Type

Motivation

Activity

shota commented on May 29, 2022

shota commented on May 29, 2022

Zelfapp commented on Jul 28, 2022

MagicLegend commented on Jul 29, 2022

Zelfapp commented on Jul 29, 2022

MagicLegend commented on Jul 29, 2022

github-actions commented on Sep 28, 2022

MagicLegend commented on Sep 28, 2022

github-actions commented on Nov 29, 2022

MagicLegend commented on Nov 29, 2022

github-actions commented on Jan 30, 2023

31 remaining items

github-actions commented on Apr 14, 2024

MagicLegend commented on Apr 15, 2024

github-actions commented on Jun 15, 2024

MagicLegend commented on Jun 17, 2024

paulomarg commented on Aug 13, 2024

MagicLegend commented on Aug 15, 2024

Suleimanlatrsh commented on Oct 6, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions