Use isolated npm trusted publishing for releases - #357
Draft
michaelrhughes wants to merge 1 commit into
Draft
michaelrhughes wants to merge 1 commit into
michaelrhughes wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
NPM_TOKENauthentication with npm trusted publishing. A read-only job builds and packs the release; a separate job has OIDC permission and publishes the tarball without installing dependencies or executing lifecycle scripts. Release dispatches must target a tag. Actions, runner versions, and the OIDC-capable Node version are pinned, and checkout credentials are not persisted.Before enabling: an npm package owner must configure the trusted publisher for
@shopify/restyleasShopify/restyle/release.yml, with no environment name. After verifying the first OIDC release, revoke the old npm token and delete the Actions secret. These administrative steps are documented in CONTRIBUTING.md; this PR does not perform them.Validated the build, all 44 tests, package creation, a token-free
npm publish --dry-run --ignore-scripts, and actionlint. The changelog is updated. No package was published, and the GitHub-to-npm OIDC exchange cannot be verified locally; keeping this draft until the trusted publisher is configured.