Fix viewability callbacks after data updates - #2494
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
datareference changed but the visible indices stayed the same, the viewability helper retained its index cache and suppressedonViewableItemsChanged. Consumers therefore continued to hold tokens for the previous items until scrolling changed visibility.Reset the existing viewability cache in the data-update path so the post-commit visibility calculation reports the replacement items. This matches React Native VirtualizedList behavior while leaving normal scroll calculations unchanged.
Reviewers’ hat-rack 🎩
Verification
jest --runInBand— 188 tests passedeslint . --ext .ts,.tsxtsc --pretty --noEmitreact-doctor . --verbose --diff— 100/100git diff --checkScreenshots or videos (if needed)
Not applicable.