Repository navigation
fix: sign macOS binaries and verify release artifacts - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published v0.5.0 macOS executable has an invalid embedded signature. macOS kills it with
SIGKILL (Code Signature Invalid)before the CLI starts, so an alias frombrewtobrewlockblocks Homebrew commands.Share the build path and apply an ad hoc signature to the final macOS executable before strict verification and packaging. Add compiled CLI checks for help, argument forwarding, stdout/stderr, successful and failing exit status, and an unchanged lock file. CI runs these checks, and release builds repeat them after extracting the tarball. Update the runtime pins to Bun 1.4.3 and prepare v0.5.1.
Validation: