Skip to content

harden: sanitize shell/subprocess call in publish.py (CWE-78) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

harden: sanitize shell/subprocess call in publish.py (CWE-78) #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
"""

import argparse
import glob
import os
import shlex
import shutil
import subprocess
import sys

Expand Down Expand Up @@ -38,9 +41,9 @@ def update_desktop_version(version):


def run_command(cmd, check=True):
"""Run a shell command and return the result."""
"""Run a command (without shell interpretation) and return the result."""
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, capture_output=True, text=True)
result = subprocess.run(shlex.split(cmd), shell=False, capture_output=True, text=True)
if check and result.returncode != 0:
print(f"Error running command: {cmd}")
print(f"stdout: {result.stdout}")
Expand All @@ -52,7 +55,8 @@ def run_command(cmd, check=True):
def clean_build():
"""Clean previous build artifacts."""
print("Cleaning previous build artifacts...")
run_command("rm -rf build/ dist/ *.egg-info/", check=False)
for path in ["build", "dist", *glob.glob("*.egg-info")]:
shutil.rmtree(path, ignore_errors=True)


def build_package():
Expand Down
Loading