Repository navigation
Fix CodeQL Swift build on macos-26 runners - #25
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
cwbooth5
force-pushed
the
fix/codeql-xcode-26
branch
from
October 9, 2026 05:08
5fd88a0 to
5d048fa
Compare
Pin Xcode 26.5 (Xcode_16.2 no longer exists on macos-latest), skip macro fingerprint validation for Mockable, build against a generic simulator destination instead of a hardcoded iOS 18.4 SDK/device, and pin action references to commit SHAs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cwbooth5
force-pushed
the
fix/codeql-xcode-26
branch
from
October 9, 2026 05:08
5d048fa to
7d91fda
Compare
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CodeQL Advanced workflow has failed on every Swift run since 2025-09-10 (and is currently disabled manually). This PR fixes the Swift job:
Xcode_16.2.app→Xcode_26.5.app.macos-latestnow resolves to the macos-26 image, which only ships Xcode 26.x. This matchesbuild-and-test.yml/publish-release.ymlonvideoand the local toolchain.defaults write com.apple.dt.Xcode IDESkipMacroFingerprintValidation -bool YESand-skipMacroValidation, needed for Mockable's Swift macros (same as the other workflows).-sdk iphonesimulator18.4 -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4'with-destination 'generic/platform=iOS Simulator'. The 2025-09 failures came from this hardcoded SDK/runtime: run logs have expired, but the annotations show xcodebuild exit 64 (unknown SDK) and, once-sdkwas dropped, exit 70 (destination not found). A generic destination doesn't depend on which simulator runtimes the image ships.actions/checkoutandgithub/codeql-action/{init,analyze}are pinned to the same commit SHAs as onvideo, since this PR now targetsvideo(Release 1.4.0: encrypted video, alphanumeric PINs #24).Caveats
video, notmain. main's code doesn't compile under Xcode 26.5 / Swift 6.3 (sending 'device' risks causing data racesinCameraFocusService.swift), and main'sbuild-and-test.ymlstill uses Xcode 26.0.1, whose iOS 26.0 platform is no longer on the runner image.videofixes both, so this lands on main together with Release 1.4.0: encrypted video, alphanumeric PINs #24.disabled_manually, so it won't run on this PR. Re-enable it withgh workflow enable codeql.yml(or from the Actions tab).github/codeql-actionv3 is deprecated in favor of v4. That bump is left for a follow-up.Test plan
videobranch: BUILD SUCCEEDEDmain: fails only on the Swift 6.3 concurrency errors above (why this targetsvideo)🤖 Generated with Claude Code