Repository navigation
Conversation
This was removed for some reason recently. We need this to be here so these views are obscured when the app is in the task switcher/background.
Wavesonics
reviewed
Oct 18, 2025
| viewModel.stopSelectingDecoys() | ||
| }) | ||
| } | ||
| .securityManaged() |
Contributor
There was a problem hiding this comment.
I think maybe we shouldnt need to do it down in each view, but I'm not 100% sure
cwbooth5
added a commit
that referenced
this pull request
Oct 12, 2026
Full-screen covers don't inherit the modifier from the presenting view, so the gallery shown during decoy selection was not obscured in the app switcher. Supersedes #21, whose other changes are covered by the navigation refactor on this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by the video branch (#24). The navigation refactor there routes the gallery detail and image info screens through ContentView's sheet/fullScreenCover, which already apply .securityManaged(). The one remaining gap — the decoy selection fullScreenCover in SettingsView — is fixed in d046ca0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed for some reason recently. We need this to be here so these views are obscured when the app is in the task switcher/background.