Repository navigation
test(upgrade): hold only the full purge to the reboot gate - #3450
Open
vpetersson-bot wants to merge 1 commit into
Open
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
The reboot-gate test asserted the gate sits above every call to the purge script. The failed-pull path now runs an `--untagged-only` sweep and exits well before the gate, so the test failed on master even though the script orders the gate and the full purge correctly. Exclude the `--untagged-only` call so the test still guards what it was written for: the full purge of superseded images stays behind the gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/test_upgrade_containers_script.py::test_reboot_gate_still_skips_the_image_purgefails on master, so every open PR gets a redrun-python-testsjob.Why
Two changes to
bin/upgrade_containers.shlanded close together:up -d, along with a test asserting the gate sits above everybash "${PURGE_SCRIPT}"call.bash "${PURGE_SCRIPT}" --untagged-onlysweep, which exits before the gate is reached.The script is correct. The test matched the new early sweep and compared the gate against it.
Change
The test now skips the
--untagged-onlycall, so it still checks what it was written for: the full purge of superseded images stays behind the reboot gate. No script changes.Testing
pytest tests/test_upgrade_containers_script.py: 4 passed (this test fails on master)ruff checkandruff format --checkare clean🤖 Generated with Claude Code