Repository navigation
fix(markup): report a client caniemail has no data for as unknown coverage - #96
Merged
Merged
Conversation
…erage caniemail throws a RangeError when a feature has data for some clients but not the one asked about (word-wrap on Gmail iOS in 2.0.2), which failed the whole compatibility check. Fill each gap in its data with its own unknown marker before asking, and report findings on filled pairs as caniemail/unknown-coverage info instead of a client claim.
commit: |
 [Medium impact] This PR appears safe to merge; the updated test addresses the earlier missing assertion. SummaryThe PR reports missing client data as source-located
Reviews (2) · Last reviewed commit: "test(markup): assert a Gmail iOS finding..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes AryaLabsHQ/samva#2974. The email compatibility check failed outright when a declaration named a feature caniemail 2.0.2 covers for some clients but not the one asked about.
word-wraphas Gmail web and Android data but no Gmail iOS entry, so caniemail threwRangeError: Feature "word-wrap" not found on "gmail.ios"and Samva'scheck_projectfailed.coverageGapsForfills each feature a target client has no entry for withu, the data's own unknown marker, and remembers those features. caniemail exposes no per-client hook, so this is the only way to keep one gap from discarding the client's whole report.caniemail/unknown-coverageinfo finding per feature, naming the clients and located at the source. Every other finding for that client is still reported, and no error or warning comes from a gap.try/catch: nothing is caught, so an unrelated caniemail failure still fails loud.word-wrapon Gmail iOS.Compiled output is unchanged; the parity digests are untouched.
Testing
bun run --filter @samva/markup test: 55 files, 1941 tests pass, including two new cases that threw before the fix (word-wrapin inline style, and in retained CSS alongside other findings).bun run --filter @samva/markup typecheck,bun run lint,bun run format:checkpass.