Skip to content

[Update] use the short SPDX form for the licence in source headers; fixes #103 - #104

Merged
samatstariongroup merged 1 commit into
developmentfrom
GH103
Oct 20, 2026
Merged

samatstariongroup merged 1 commit into
developmentfrom
GH103

Conversation

@samatstariongroup

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the ReqIFSharp code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fixes #103.

The 17-line Apache-2.0 notice at the top of every C# source file is replaced by the short SPDX form, inside the existing <copyright> block:

// -------------------------------------------------------------------------------------------------
// <copyright file="ReqIF.cs" company="Starion Group S.A.">
//
//   SPDX-FileCopyrightText: 2017-2026 Starion Group S.A.
//   SPDX-License-Identifier: Apache-2.0
//
// </copyright>
// ------------------------------------------------------------------------------------------------

The licence itself does not change: the full text stays in LICENSE, and the packages keep PackageLicenseExpression Apache-2.0.

Changes

  • All 145 .cs files: only the header comment changed (every changed line is a // comment, within the old 19-line header); BOMs are kept. Headers with an extra space of indentation are normalized.
  • Three headers named another file; they now name their own file: EmbeddedValueTestFixture.cs (was AttributeValueXHTMLTestFixture.cs), ReqIfPropertyAttributeTestFixture.cs (was PropertyAttributeTestFixture.cs) and AlternativeID.cs (was AlternativeId.cs).
  • ReqIFSharp.sln.DotSettings: the ReSharper file-header template produces the short form for new files (it also said 2017-2025).
  • NOTICE: 2014-2026 → 2017-2026, the range of the headers and Directory.Build.props (the first commit is from 2017).
  • CLAUDE.md: the header convention describes the short form.
  • CHANGELOG.md: entry under [Unreleased] → Changed.

Decisions (from the open points in the issue)

  • The <copyright file=... company=...> block is kept around the SPDX lines.
  • One year range everywhere: 2017-2026.
  • No REUSE configuration (REUSE.toml) or REUSE check in CI in this change; it can be a follow-up.

Verification

  • git grep "Licensed under the Apache License" finds only LICENSE and NOTICE; every .cs file has SPDX-FileCopyrightText and SPDX-License-Identifier.
  • dotnet build -c Release: 0 warnings; dotnet test: 620 passed.

🤖 Generated with Claude Code

…ixes #103

- Replace the Apache-2.0 notice in the header of all 145 .cs files with
  SPDX-FileCopyrightText: 2017-2026 Starion Group S.A. and
  SPDX-License-Identifier: Apache-2.0, inside the existing <copyright>
  block. Only header comments change; BOMs are kept.
- Correct three headers that named another file.
- Update the ReSharper file-header template (it also said 2017-2025).
- Use 2017-2026 in NOTICE, as in the headers and Directory.Build.props.
- Describe the short form in the CLAUDE.md conventions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@samatstariongroup
samatstariongroup merged commit 6b33f7e into development Oct 20, 2026
8 checks passed
@samatstariongroup
samatstariongroup deleted the GH103 branch October 20, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Replace the Apache-2.0 notice in source headers with the short SPDX form

1 participant