Fix missing model name in console error output for driver failures) - #6066
sakshipatil-hue wants to merge 3 commits into
Conversation
|
Hey @sakshipatil-hue Before we go further on the patch, could you open a GitHub issue with more detail on the failure you hit? The current change adds fallbacks in In the issue, please include:
Also, as a reminder: when submitting a PR please make sure your commits are DCO signed |
|
@sakshipatil-hue -- is this the issue you're trying to resolve: #6064 ? -- adding a comment on the issue with your own details might be helpful! |
|
@cmgoffena13-- Yes, #6064 is indeed the issue I am addressing! To provide the context requested:
I will also ensure my commits are DCO signed off shortly. Thanks for reviewing! |
Signed-off-by: Sakshi Patil <sakshipatil@users.noreply.github.com>
Description
Fixes an issue where low-level driver or engine errors (such as casting exceptions) fail to display the failing model or snapshot name in the console error output.
Updated
_format_node_errorinsqlmesh/core/console.pyto add robust fallback checks. Iferror.nodelacks standardsnapshot_nameorSnapshotIdattributes, it now checks for a.nameattribute or safely falls back to stringifying the node (str(error.node)), ensuring the failing model name is always surfaced in logs.Test Plan
Manually verified that when a node execution fails due to low-level engine or driver errors where
error.nodelacks standard snapshot attributes, the console correctly falls back to.nameorstr(error.node)and successfully outputs the failing model name instead of leaving it blank.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO