Set CableTime to 0 ns for readout cable delay - #948
asanchezcastillo wants to merge 1 commit into
Conversation
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_22_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_22_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Hi @asanchezcastillo , the checklist shows that this PR affects the CAF data format, but a CAF maintainer was not assigned as a reviewer? Just checking if this PR actually affects the CAF data format. Also, the CI tests show differences in some data products like: DetSim | pmtpulseoscillation | | std::vectorraw::OpDetWaveform. Maybe this is expected due to the cable delay change, but just confirming with you and @VCLanNguyen to make sure this is desired behavior? |
|
Hi @aantonakis. The PR does not change the CAFs, it was just a typo on the checklist. I have modified the checklist to reflect it. I have checked the CI warnings and everything looks as it should. The difference in the data products is cause by the cable delay changing the waveform size by a couple of ticks, which is expected. |
Description
PMT cable delay was being simulated but not corrected downstream, producing a time shift in the reconstructed timing objects. This PR removes the cable delay simulation.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?