Conversation
Upper/Lower bounds updated via resource warnings in Jenkins CI dashboard. New reference files introduced as of icarus_ci build 15201, and these bounds were tuned via builds 15211, 15218, and 15222.
jas1005
requested review from
cerati and
vitodb
and
a lite review from Copilot
September 11, 2026 18:37
There was a problem hiding this comment.
🟡 Changes recommended
Calibrate or justify the unchanged reco0 thresholds in the active quick-test suite.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates quick CI resource bounds using recent Jenkins calibration data.
Changes:
- Recalibrates CPU and memory ranges for quick tests.
- Updates calibration metadata and removes a redundant commented suite entry.
- Requires updating or documenting the unchanged
reco0thresholds.
File summaries
| File | Summary |
|---|---|
test/ci/ci_tests.cfg |
Updates quick-test resource limits; reco0 remains on potentially stale thresholds. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+704
to
+706
| # Calibrated with [e26] via Jenkins dashboard values on September 10th, 2026 | ||
| cpu_usage_range=300:500 | ||
| mem_usage_range=2250000:3500000 |
cerati
approved these changes
Sep 11, 2026
cerati
left a comment
cerati
left a comment
Contributor
There was a problem hiding this comment.
I do not see anything wrong, and the change in requirements seem reasonable. Vito might have more insights. Also, I am not sure what the Copilot comment means. But as far as I am concerned this is approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upper/Lower bounds updated via resource warnings in Jenkins CI dashboard. New reference files introduced as of icarus_ci build 15201, and these bounds were tuned via builds 15211, 15218, and 15222.