Tuned hit finder parameters

[mattiasotgia]

This PR introduces the updated hit finder parameters values obtained after the latest tuning.

Details can be found in the latest presentation given at the sim/reco ICARUS WG meeting, found on docdb-48139.

Description

This refactor the dependencies of the hit finder module across the FHiCL in stage1, removing the outdated sbn default and introducing the ICARUS-tailored version.

In hitfindermodules_icarus.fcl the updated parameter values are set, and the NextADCThreshold parameter value is introduced for the candidate hit finder module.

Depends on

This PR has been done as part of an infrastructure-wide attempt of freezing the code up to a certain version. The following is a list of (both closed/merged and open) PR that have been included as part of the validation studies.

• Adding "safe-guards" to avoid segfault in the GaussHitFinderSBN module sbncode#659
• Per Plane Hit Tuning Parameters for GaussHitFinderSBN sbncode#626
• Optical sim/reco and overlay updates #892
• CandHitStandard nextADCThreshold Parameter LArSoft/larreco#92

Additionally, it requires the following to be merged to address some issues that we've been seeing on shower like topologies

• Updates to the Pandora shower-dE/dx reconstruction settings #855 (this is dependent on Override plane-by-plane the result from the trajectory-based dE/dx tool PandoraPFAOrg/larpandora#32, thus requiring a newer version of the PandoraPFA/larpandora dependency)

This will also require develop to be on the same page as release/SBN2025A since this was cut starting from there.

Asking @acampani, @cerati and @SFBayLaser for a review.

[cerati]

I left a couple of minor comments, should be easy to move to approval soon. Thanks!

[cerati]

for my curiosity, how worse was a tuned version that disabled long hits?

[mattiasotgia]

I did not check this, but I'll put in my TODO list and get to it as soon as possible -- it should not take a long time to re-spin my small production with this small update and have some plots shared

[mattiasotgia]

Following the work presented in SBN DocDB 48490 I reverted LongMaxHits to be 1 for every TPC plane (this disables pulse trains)

[jas1005]

trigger build larsoft@v10_24_00 LArSoft/lar*@LARSOFT_SUITE_v10_24_00 SBNSoftware/sbnalg@v10_24_00 SBNSoftware/sbnobj@v10_23_00 SBNSoftware/sbnanaobj@v10_23_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_24_00 SBNSoftware/icarusalg@v10_24_00 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_24_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard