Skip to content

Add HitWidthClusterMerging algorithms in Pandora steering XML and enabling hit widths - #909

Open
mattiasotgia wants to merge 2 commits into
developfrom
feature/msotgia_widths_pandora_reconstruction
Open

mattiasotgia wants to merge 2 commits into
developfrom
feature/msotgia_widths_pandora_reconstruction

Conversation

@mattiasotgia

Copy link
Copy Markdown
Contributor

Description

This PR introduces in the Pandora reconstruction chain a couple of algorithms aimed at exploiting the hit width information to improve on the 2D cluster creation.

In addition to the change in the Pandora steering XML, the flag UseHitWidths is switched to true in the pandoramodules_icarus.fcl configuration.

Requesting review to @rtriozzi and @acampani, please let me know if anyone else should be added as reviewer for this PR.

@mattiasotgia
mattiasotgia requested review from acampani and rtriozzi July 4, 2026 07:05
@mattiasotgia mattiasotgia self-assigned this Jul 4, 2026
@mattiasotgia mattiasotgia added the enhancement New feature or request label Jul 4, 2026

@rtriozzi rtriozzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks as expected.

(was there any chance of introducing the width-based algos in the cosmic pass as well? if so, should we bake them in eventually? anyway, this is good to go as is imo!)

@mattiasotgia

Copy link
Copy Markdown
Contributor Author

was there any chance of introducing the width-based algos in the cosmic pass as well?

I think introducing the same algorithms also in the slicing pass (i.e., the first Pandora cosmic pass) would be something to investigate further.

As is now, the second Pandora cosmic pass is essentially not being used for anything, since we are saving the output of the Pandora neutrino path for all slices, so I don't have strong feelings for that one, but I agree changing the first Pandora cosmic pass could be a nice improvement.

@jas1005

jas1005 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

trigger build larsoft@v10_24_00 LArSoft/lar*@LARSOFT_SUITE_v10_24_00 SBNSoftware/sbnalg@v10_24_00 SBNSoftware/sbnobj@v10_23_00 SBNSoftware/sbnanaobj@v10_23_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_24_00 SBNSoftware/icarusalg@v10_24_00 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_24_00

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants