Fix issue where CRT HitTree in calibration tuples did not store run number [Develop] - #861
francescopoppi wants to merge 2 commits into
Conversation
…r were left uninitialized.
…d added TriggerTimestamp variable to DAQTree.
|
I'm going through old PRs and it looks like this one never got approved. I realize the number of changes isn't trivial, but I hope your relative familiarity with the code will make things easier. Do you have time to review this PR or should I ask someone else? Would you like me to ask someone else to also review this PR? |
aheggest
left a comment
aheggest
left a comment
There was a problem hiding this comment.
I approve these changes.
|
trigger build larsoft@v10_24_00 LArSoft/lar*@LARSOFT_SUITE_v10_24_00 SBNSoftware/sbnalg@v10_24_00 SBNSoftware/sbnobj@v10_23_00 SBNSoftware/sbnanaobj@v10_23_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_24_00 SBNSoftware/icarusalg@v10_24_00 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_24_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
4 participants
[Develop Version]
This PR fixes a bug where due to the fact CRTData were dropped from Stage0, running Stage1 did not fill run number and sub run number. This caused the usage of uninitialized variables. This error was spotted thanks to @mt82 who did consistency checks between productions.
On a side note, I cleaned the code from some bad indentation that made the code unreadable.
I also added Trigger Timestamp to the DAQTree, it should have been there since the beginning.