Conversation
Replace the if/elif chain in _build_expression with a PEP 634 match/case statement, removing the need for pylint suppressions of too-many-return-statements and too-many-branches. Part of #302.
pylint 2.11.0 is the first release bundling astroid 2.9.x, which added visit_match — required to lint Python 3.10 match/case statements without crashing. This is intentionally minimal pylint bump, even that pylint is currently 2 major versions above - there are too much new failures when trying the latest linter. Part of #302.
Disable C0209, R1735, R1734, and W0602 globally in .pylintrc, and add an inline too-many-return-statements suppression to _build_expression where match/case inherently exceeds the return-count limit. Fixes for those will be tracked in a follow-up PR. Part of #302.
pylint 2.11.0 depends on wrapt<1.14 which fails to build on Python 3.11 because inspect.formatargspec was removed. pylint 2.15.0 requires wrapt>=1.14 which supports Python 3.11. Part of #302.
Remove obsolete .pylintrc options dropped in pylint 2.14/2.15 (optimize-ast, files-output, no-space-check, *-name-hint keys) and globally suppress unrecognized-option / useless-option-value. Remove 32 inline no-self-use suppressions from model.py and service.py that now trigger R0022 because no-self-use was moved to an optional extension in pylint 2.14. Part of #302.
Contributor
Author
|
This is a "small pain" towards bigger goal.
|
filak-sap
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the if/elif chain in _build_expression with a PEP 634 match/case statement, removing the need for pylint suppressions of too-many-return-statements and too-many-branches.
Part of #302.