-
Notifications
You must be signed in to change notification settings - Fork 45
feat(agentgateway): list connected systems and filter MCP tools by GTID #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lentzvitoria
wants to merge
14
commits into
SAP:main
Choose a base branch
from
lentzvitoria:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+766
−19
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5e01c4c
add global id filter for lob agents
lentzvitoria a819325
Add listing of sanatized integrations.
intomg1990 57258d6
feat(agentgateway): switch to label-based integration metadata and ad…
intomg1990 4e84b80
fix(agentgateway): return system_type as None instead of skipping fra…
intomg1990 6cbd3e5
Merge pull request #1 from I542102/feat/AFSDK-4288
lentzvitoria cc75492
chore: merge main into vl-filter-fragment, resolve label constant con…
lentzvitoria d1111b6
Merge pull request #2 from I542102/vl-filter-fragment
lentzvitoria 73e65f7
Merge branch 'SAP:main' into main
lentzvitoria 804e3ec
feat(agentgateway): address PR review comments for connected systems …
lentzvitoria 881538d
fix(agentgateway): align gtids rename across fragments, tests and doc…
lentzvitoria 6c97a36
fix(agentgateway): add ConnectedSystem model and fix CI failures
intomg1990 789ddbe
fix(agentgateway): remove unused Optional import from _fragments.py
intomg1990 fa782b8
fix pydantic error
lentzvitoria 4b5b761
chore: merge upstream SAP/cloud-sdk-python main
lentzvitoria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| Feature: Agent Gateway Connected Systems Integration | ||
| As a LoB agent developer using the SDK | ||
| I want to discover which backend systems are connected for my tenant | ||
| So that I can scope MCP tool discovery to specific systems | ||
|
|
||
| Background: | ||
| Given the Agent Gateway client is available | ||
|
|
||
| Scenario: List connected systems returns a list | ||
| When I call list_active_integrations | ||
| Then the result should be a list of ConnectedSystem | ||
|
|
||
| Scenario: Each connected system has required fields | ||
| When I call list_active_integrations | ||
| Then each connected system should have a non-empty global_tenant_id | ||
| And each connected system should have a non-null integration_dependency or system_type | ||
|
|
||
| Scenario: Connected systems with missing labels are still returned | ||
| When I call list_active_integrations | ||
| Then fragments with missing labels should appear with None values | ||
|
|
||
| Scenario: List MCP tools filtered by GTID from connected system | ||
| When I call list_active_integrations | ||
| And at least one connected system is present | ||
| When I call list_mcp_tools filtered by the first connected system gtid | ||
| Then the result should be a list of MCPTool | ||
|
|
||
| Scenario: Customer agent cannot call list_active_integrations | ||
| Given a customer agent client is configured | ||
| When I call list_active_integrations with the customer agent client | ||
| Then the operation should fail with AgentGatewaySDKError | ||
| And the error message should mention "not supported for customer agents" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.