LTI1p3: drop detailed logging to DEBUG level - #1527
Merged
bnmnetp merged 1 commit intoSep 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The updated logging introduces/retains error-path issues (exception handling when no response exists) and continues to log potentially sensitive data via r.__dict__/raw bodies.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adjusts LTI 1.3 service-connector logging so verbose HTTP failure details are emitted at DEBUG level, keeping production logs quieter while preserving diagnostics for development.
Changes:
- Downgrades several
get_access_token()failure logs from ERROR to DEBUG and reduces the amount of response detail logged. - Downgrades
make_service_request()failure logging from ERROR to DEBUG (while keeping detailed response logging).
| File | Description |
|---|---|
| components/rsptx/lti1p3/pylti1p3/service_connector.py | Moves LTI1p3 HTTP failure logging to DEBUG and adjusts what response details are logged. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
121
to
125
| except Exception: | ||
| raw_body = await r.text() | ||
| rslogger.error( | ||
| f"get_access_token exception caught: {r.status} - {r.reason}. Headers: {r.headers}. Full response: {r.__dict__}" | ||
| rslogger.debug( | ||
| f"get_access_token exception caught: {r.status} - {r.reason}. Headers: {r.headers}." | ||
| ) |
ascholerChemeketa
force-pushed
the
lti-debug-drop
branch
from
September 20, 2026 16:22
01f204f to
b3826a1
Compare
Contributor
Author
|
Fixed the unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the new detailed logging for LTI1p3 to DEBUG level. That should keep it out of production but keep it available in dev instances.